-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coredump restore application isolate with board_crashdump #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coredump should compatible with default 32B NAME_MAX Signed-off-by: buxiasen <[email protected]>
Signed-off-by: buxiasen <[email protected]>
Signed-off-by: buxiasen <[email protected]>
Signed-off-by: buxiasen <[email protected]>
[Experimental Bot, please feedback here] This PR does not fully meet the NuttX requirements as documented. While it provides some information, it lacks crucial details and formatting. Here's a breakdown: Missing/Insufficient Information:
How to Improve the PR:
By addressing these points, the PR will be much clearer, easier to review, and more likely to be accepted. |
xiaoxiang781216
approved these changes
Nov 29, 2024
anchao
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pervious coredump is depend on board_crashdump enabled,
but for some use case, we need to not open crashdump and open coredump restore.
for example AMP case.
also we already finished the blkout stream seek support, should make coredump infomation seek only depend on seek API.
should work with
apache/nuttx#14997
if want using coredump to blk/mtd -> reboot -> restore to filesystem -> adb/ymodem/.. this kind of workflow.
Impact
the coredump infomation position has changed, we now able to put more data in coredump section.
we now able to close board_crash dump and open crash dump restore.
Testing
CI test, local arm-v8m board.