-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crashdump change to choice, add coredump to mtd support based on mtdout stream. #14997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: buxiasen <[email protected]>
Signed-off-by: buxiasen <[email protected]>
Signed-off-by: wanggang26 <[email protected]> Signed-off-by: buxiasen <[email protected]>
Signed-off-by: buxiasen <[email protected]>
github-actions
bot
added
Arch: renesas
Issues related to the Renesas chips
Area: OS Components
OS Components issues
Size: M
The size of the change in this PR is medium
labels
Nov 29, 2024
For only board specific crashdump and no syslog/blk/mtd coredump Signed-off-by: buxiasen <[email protected]>
[Experimental Bot, please feedback here] This PR appears to mostly meet the NuttX requirements, but some areas could be improved for clarity and completeness. Strengths:
Weaknesses:
Recommendation: Revise the PR description to address the weaknesses outlined above. Providing greater detail and explicitly addressing all points in the template will improve clarity and make the review process smoother. |
acassis
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Arch: renesas
Issues related to the Renesas chips
Area: OS Components
OS Components issues
Size: M
The size of the change in this PR is medium
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pervious coredump to device based on blk geo information, and not easy to extend,
we changed it to seek api, so the coredump to device should more common, and also possible to mtd directly.
for the small device should be more effeciency. As we don't have to use blk/bch/ftl/mtd. both code size and memory will be decreasd.
Also as we removed the geo information requirments, the alloc of g_blockinfo can be removed.
should work with
apache/nuttx-apps#2871
if want using coredump to blk/mtd -> reboot -> restore to filesystem -> adb/ymodem/.. this kind of workflow.
Kept the compatible with
board_crashdump
API by BOARD_CRASHDUMP_CUSTOM, and it's a choice which exclusive with coredump syslog/blk/mtd.
Should compatible with the current running project/defconfig.
Impact
the coredump infomation position has changed, we now able to put more data in coredump section.
support coredump to mtd (especially norflash)
board_crashdump will not be call if using coredump syslog/blk/mtd.
if we further have more storage device type, will be easier to add support.
Testing
CI-test & local arm-v8m board, local arm-v7a board.