Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/qemu: Open kasan on qemu #14055

Merged
merged 1 commit into from
Oct 14, 2024
Merged

boards/qemu: Open kasan on qemu #14055

merged 1 commit into from
Oct 14, 2024

Conversation

W-M-R
Copy link
Contributor

@W-M-R W-M-R commented Oct 10, 2024

Summary

  1. Open Kasan and open Kasantest
  2. Add software tag kasan configuration for arm64

Impact

Testing

@github-actions github-actions bot added Board: arm Board: arm64 Size: S The size of the change in this PR is small labels Oct 10, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 10, 2024

[Experimental Bot, please feedback here]

NuttX PR Requirements Review

Missing Information:

This PR description is missing crucial information to determine if it meets NuttX requirements.

Specifically:

  • Summary:
    • Why are these changes necessary? What problem do they solve or feature do they add?
    • What functional part of the code is impacted (e.g., memory management, specific architecture)?
    • How do these changes work? Provide technical details about Kasan/Kasantest implementation.
  • Impact:
    • Address all impact points with specific details about how the PR affects each. For example, "Impact on build: YES - Requires enabling the 'kasan' config option."
  • Testing:
    • Provide specific build host and target details (OS, architecture, compiler versions, board names).
    • Include actual testing logs before and after the changes. "your testing logs here" is not helpful.

Recommendations:

  1. Elaborate on the "Summary" section with detailed explanations.
  2. Thoroughly address each "Impact" point, even if the answer is "NO". If "YES", provide a clear explanation.
  3. Replace placeholders in "Testing" with actual information about your testing environment and relevant logs.

Without this information, it's impossible to determine if the PR meets NuttX requirements.

@xiaoxiang781216
Copy link
Contributor

@W-M-R W-M-R force-pushed the kasan branch 2 times, most recently from df319dc to d273981 Compare October 11, 2024 07:18
@github-actions github-actions bot added Size: M The size of the change in this PR is medium and removed Size: S The size of the change in this PR is small labels Oct 11, 2024
@W-M-R
Copy link
Contributor Author

W-M-R commented Oct 11, 2024

@github-actions github-actions bot added Size: S The size of the change in this PR is small and removed Area: Tooling Area: CI Size: M The size of the change in this PR is medium labels Oct 11, 2024
@W-M-R W-M-R closed this Oct 12, 2024
@W-M-R W-M-R deleted the kasan branch October 12, 2024 02:22
@W-M-R W-M-R restored the kasan branch October 12, 2024 02:27
@W-M-R W-M-R reopened this Oct 12, 2024
@W-M-R W-M-R force-pushed the kasan branch 4 times, most recently from 5d480a3 to a1465fd Compare October 14, 2024 07:59
1. Open Kasan and open Kasantest
2. Add software tag kasan configuration for arm64

Signed-off-by: wangmingrong1 <[email protected]>
@xiaoxiang781216 xiaoxiang781216 merged commit 0b88958 into apache:master Oct 14, 2024
39 checks passed
@W-M-R W-M-R deleted the kasan branch October 16, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Board: arm Board: arm64 Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants