Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GCCVER define to Toolchain. #14130

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Add GCCVER define to Toolchain. #14130

merged 1 commit into from
Oct 19, 2024

Conversation

cuiziwei1
Copy link
Contributor

@cuiziwei1 cuiziwei1 commented Oct 11, 2024 •
edited
Loading

Summary

We hope to find a common place to define GCCVER, so that it only needs to be specified once, which would undoubtedly be the most convenient. #14130 (comment). However, since GCCVER may be used in the Toolchain.defs of each architecture, we have to define GCCVER again.#14293 (comment)

Impact

Testing

@github-actions github-actions bot added Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Size: S The size of the change in this PR is small labels Oct 11, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 11, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

The provided information only includes a build error message and lacks essential details outlined in the NuttX PR requirements.

Here's what's missing:

  • Summary: No information is provided about the purpose, functionality, or implementation of the change.
  • Impact: The impact on users, the build process, hardware, documentation, security, compatibility, and other considerations is entirely absent.
  • Testing: While error logs are partially included, there's no context about the testing environment (host and target), the nature of the tests performed, or the expected behavior.

To meet the NuttX requirements, the PR needs to provide a comprehensive description of the change, its impact, and thorough testing evidence, following the template provided.

@cuiziwei1 cuiziwei1 mentioned this pull request Oct 11, 2024
Closed
1 task
@xiaoxiang781216 xiaoxiang781216 linked an issue Oct 12, 2024 that may be closed by this pull request
[BUG] Compile options broken on GCC 9 #13776
Closed
1 task
anchao
anchao requested changes Oct 12, 2024
View reviewed changes
arch/risc-v/src/cmake/Toolchain.cmake Outdated Show resolved Hide resolved
@anchao
Copy link
Contributor

anchao commented Oct 12, 2024

Please make some improvements for revert back commits and make each change more valuable, rather than revert,revert "revert",revert "revert "revert"" in daily work

@github-actions github-actions bot added Size: XS The size of the change in this PR is very small and removed Size: S The size of the change in this PR is small labels Oct 12, 2024
@cuiziwei1 cuiziwei1 mentioned this pull request Oct 12, 2024
Merged
@cuiziwei1 cuiziwei1 force-pushed the fix_risc-v_flags branch 2 times, most recently from 1f873eb to 43fb27a Compare October 14, 2024 06:32
@github-actions github-actions bot added Size: S The size of the change in this PR is small and removed Size: XS The size of the change in this PR is very small labels Oct 14, 2024
@cuiziwei1 cuiziwei1 force-pushed the fix_risc-v_flags branch 4 times, most recently from 017dbe1 to 6333af2 Compare October 16, 2024 03:37
@cuiziwei1 cuiziwei1 changed the title risc-v: Fix risc-gnu-toolchain -march=rv64imafdc_zicsr_zifencei error. Add GCCVER define to Toolchain.cmake Oct 16, 2024
@github-actions github-actions bot added Arch: arm Issues related to ARM (32-bit) architecture Arch: arm64 Issues related to ARM64 (64-bit) architecture labels Oct 16, 2024
@cuiziwei1 cuiziwei1 changed the title Add GCCVER define to Toolchain.cmake Add GCCVER define to Toolchain. Oct 16, 2024
@xiaoxiang781216
Copy link
Contributor

please fixtheconflict, @cuiziwei1

@cuiziwei1 cuiziwei1 force-pushed the fix_risc-v_flags branch 4 times, most recently from 9a101c0 to 761a00a Compare October 17, 2024 03:52
@github-actions github-actions bot added Size: M The size of the change in this PR is medium and removed Size: S The size of the change in this PR is small labels Oct 17, 2024
@cuiziwei1 cuiziwei1 force-pushed the fix_risc-v_flags branch 2 times, most recently from 2dd979b to 099b3c9 Compare October 17, 2024 03:55
@github-actions github-actions bot added Size: S The size of the change in this PR is small and removed Area: OS Components OS Components issues Size: M The size of the change in this PR is medium labels Oct 17, 2024
@github-actions github-actions bot added Arch: xtensa Issues related to the Xtensa architecture Size: M The size of the change in this PR is medium and removed Size: S The size of the change in this PR is small labels Oct 17, 2024
xiaoxiang781216
xiaoxiang781216 reviewed Oct 17, 2024
View reviewed changes
arch/arm64/src/Toolchain.defs Outdated Show resolved Hide resolved
arch/risc-v/src/cmake/Toolchain.cmake Outdated Show resolved Hide resolved
arch/risc-v/src/common/Toolchain.defs Outdated Show resolved Hide resolved
arch/xtensa/src/lx6/Toolchain.defs Outdated Show resolved Hide resolved
arch/xtensa/src/lx7/Toolchain.defs Outdated Show resolved Hide resolved
@cuiziwei1 cuiziwei1 force-pushed the fix_risc-v_flags branch 7 times, most recently from 4e9a9a0 to 916b0d1 Compare October 18, 2024 16:25
@cuiziweizw
Add GCCVER define to Toolchain.cmake
64f03df 
Since GCCVER will also be used in the toolchain, it needs to be defined in advance.

Signed-off-by: cuiziwei <[email protected]>
@xiaoxiang781216 xiaoxiang781216 merged commit 9614e1f into apache:master Oct 19, 2024
29 checks passed
@xiaoxiang781216 xiaoxiang781216 mentioned this pull request Oct 19, 2024
Closed
1 task
@cuiziwei1 cuiziwei1 deleted the fix_risc-v_flags branch November 8, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuxin930 xuxin930 xuxin930 left review comments

@pkarashchenko pkarashchenko pkarashchenko approved these changes

@anchao anchao anchao requested changes

@hartmannathan hartmannathan hartmannathan approved these changes

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

Assignees
No one assigned
Labels
Arch: arm Issues related to ARM (32-bit) architecture Arch: arm64 Issues related to ARM64 (64-bit) architecture Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: xtensa Issues related to the Xtensa architecture Area: Build system Area: Tooling Size: M The size of the change in this PR is medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Compile options broken on GCC 9
8 participants
@cuiziwei1 @nuttxpr @anchao @xiaoxiang781216 @pkarashchenko @xuxin930 @hartmannathan @cuiziweizw