[fix][doc]Correcting spelling mistakes in the pulsar-broker module #23758
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc
lhotari
requested changes
Dec 20, 2024
| @@ -3140,7 +3140,7 @@ public void checkGC() { | |||
| * "replicator.producer" to a null value. | |||
| * Race condition: task 1 will get a NPE when it tries to send messages using the variable | |||
| * "replicator.producer", because task 2 will set this variable to "null". | |||
| * TODO Create a seperated PR to fix it. | |||
| * TODO Create a separated PR to fix it. | |||
There was a problem hiding this comment.
Suggested change
| * TODO Create a separated PR to fix it. | |
| * TODO Create a separate PR to fix it. |
| @@ -135,7 +135,7 @@ protected void verifyPartitionsNeverCreated(String topicNameStr) throws Exceptio | |||
| } catch (Exception ex) { | |||
| // If the namespace bundle has not been loaded yet, it means no non-persistent topic was created. So | |||
| // this behavior is also correct. | |||
| // This error is not expected, a seperated PR is needed to fix this issue. | |||
| // This error is not expected, a separated PR is needed to fix this issue. | |||
There was a problem hiding this comment.
Suggested change
| // This error is not expected, a separated PR is needed to fix this issue. | |
| // This error is not expected, a separate PR is needed to fix this issue. |
| @@ -148,7 +148,7 @@ protected void verifyNonPartitionedTopicNeverCreated(String topicNameStr) throws | |||
| } catch (Exception ex) { | |||
| // If the namespace bundle has not been loaded yet, it means no non-persistent topic was created. So | |||
| // this behavior is also correct. | |||
| // This error is not expected, a seperated PR is needed to fix this issue. | |||
| // This error is not expected, a separated PR is needed to fix this issue. | |||
There was a problem hiding this comment.
Suggested change
| // This error is not expected, a separated PR is needed to fix this issue. | |
| // This error is not expected, a separate PR is needed to fix this issue. |
| @@ -155,7 +155,7 @@ private double getTotalCpuUsageForCGroup(double elapsedTimeSeconds) { | |||
| * </pre> | |||
| * | |||
| * Line is split in "words", filtering the first. The sum of all numbers give the amount of cpu cycles used this | |||
| * far. Real CPU usage should equal the sum substracting the idle cycles(that is idle+iowait), this would include | |||
| * far. Real CPU usage should equal the sum subtracting the idle cycles(that is idle+iowait), this would include | |||
There was a problem hiding this comment.
Suggested change
| * far. Real CPU usage should equal the sum subtracting the idle cycles(that is idle+iowait), this would include | |
| * far. Real CPU usage should equal the sum after subtracting the idle cycles (that is idle+iowait), this would include |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: