-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][doc]Correcting spelling mistakes in the pulsar-broker module #23758
Open
daziz
wants to merge
1
commit into
apache:master
Choose a base branch
from
daziz:fix-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -328,7 +328,7 @@ private static class EstimateTimeBasedBacklogQuotaCheckResult { | |||||
* 2. Namespace bundle transfer or unloading. | ||||||
* a. The unloading topic triggered by unloading namespace bundles will not wait for clients disconnect. Relate | ||||||
* to {@link CloseFutures#notWaitDisconnectClients}. | ||||||
* b. The unloading topic triggered by unloading namespace bundles was seperated to two steps when using | ||||||
* b. The unloading topic triggered by unloading namespace bundles was separated to two steps when using | ||||||
* {@link ExtensibleLoadManagerImpl}. | ||||||
* b-1. step-1: fence the topic on the original Broker, and do not trigger reconnections of clients. Relate | ||||||
* to {@link CloseFutures#transferring}. This step is a half closing. | ||||||
|
@@ -3140,7 +3140,7 @@ public void checkGC() { | |||||
* "replicator.producer" to a null value. | ||||||
* Race condition: task 1 will get a NPE when it tries to send messages using the variable | ||||||
* "replicator.producer", because task 2 will set this variable to "null". | ||||||
* TODO Create a seperated PR to fix it. | ||||||
* TODO Create a separated PR to fix it. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
*/ | ||||||
closeReplProducersIfNoBacklog().thenRun(() -> { | ||||||
if (hasRemoteProducers()) { | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -135,7 +135,7 @@ protected void verifyPartitionsNeverCreated(String topicNameStr) throws Exceptio | |||||
} catch (Exception ex) { | ||||||
// If the namespace bundle has not been loaded yet, it means no non-persistent topic was created. So | ||||||
// this behavior is also correct. | ||||||
// This error is not expected, a seperated PR is needed to fix this issue. | ||||||
// This error is not expected, a separated PR is needed to fix this issue. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
assertTrue(ex.getMessage().contains("Failed to find ownership for")); | ||||||
} | ||||||
} | ||||||
|
@@ -148,7 +148,7 @@ protected void verifyNonPartitionedTopicNeverCreated(String topicNameStr) throws | |||||
} catch (Exception ex) { | ||||||
// If the namespace bundle has not been loaded yet, it means no non-persistent topic was created. So | ||||||
// this behavior is also correct. | ||||||
// This error is not expected, a seperated PR is needed to fix this issue. | ||||||
// This error is not expected, a separated PR is needed to fix this issue. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
assertTrue(ex.getMessage().contains("Failed to find ownership for")); | ||||||
} | ||||||
} | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.