Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][doc]Correcting spelling mistakes in the pulsar-broker module #23758

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ public static void main(String[] args) throws Exception {
try {
initializeCluster(arguments, bundleNumberForDefaultNamespace);
} catch (Exception e) {
System.err.println("Unexpected error occured.");
System.err.println("Unexpected error occurred.");
e.printStackTrace(System.err);
System.err.println("Terminating JVM...");
ShutdownUtil.triggerImmediateForcefulShutdown();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ private double getTotalCpuUsageForCGroup(double elapsedTimeSeconds) {
* </pre>
*
* Line is split in "words", filtering the first. The sum of all numbers give the amount of cpu cycles used this
* far. Real CPU usage should equal the sum substracting the idle cycles(that is idle+iowait), this would include
* far. Real CPU usage should equal the sum subtracting the idle cycles(that is idle+iowait), this would include
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* far. Real CPU usage should equal the sum subtracting the idle cycles(that is idle+iowait), this would include
* far. Real CPU usage should equal the sum after subtracting the idle cycles (that is idle+iowait), this would include

* cpu, user, nice, system, irq, softirq, steal, guest and guest_nice.
*/
private double getTotalCpuUsageForEntireHost() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ public boolean consumeTokensAndCheckIfContainsTokens(long consumeTokens) {
} else if (currentTokens == Long.MIN_VALUE) {
// when currentTokens is Long.MIN_VALUE, the current tokens balance is unknown since consumed tokens
// was added to the pendingConsumedTokens LongAdder counter. In this case, assume that tokens balance
// hasn't been updated yet and calculate a best guess of the current value by substracting the consumed
// hasn't been updated yet and calculate a best guess of the current value by subtracting the consumed
// tokens from the current tokens balance
return tokens - consumeTokens > 0;
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ private static class EstimateTimeBasedBacklogQuotaCheckResult {
* 2. Namespace bundle transfer or unloading.
* a. The unloading topic triggered by unloading namespace bundles will not wait for clients disconnect. Relate
* to {@link CloseFutures#notWaitDisconnectClients}.
* b. The unloading topic triggered by unloading namespace bundles was seperated to two steps when using
* b. The unloading topic triggered by unloading namespace bundles was separated to two steps when using
* {@link ExtensibleLoadManagerImpl}.
* b-1. step-1: fence the topic on the original Broker, and do not trigger reconnections of clients. Relate
* to {@link CloseFutures#transferring}. This step is a half closing.
Expand Down Expand Up @@ -3140,7 +3140,7 @@ public void checkGC() {
* "replicator.producer" to a null value.
* Race condition: task 1 will get a NPE when it tries to send messages using the variable
* "replicator.producer", because task 2 will set this variable to "null".
* TODO Create a seperated PR to fix it.
* TODO Create a separated PR to fix it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* TODO Create a separated PR to fix it.
* TODO Create a separate PR to fix it.

*/
closeReplProducersIfNoBacklog().thenRun(() -> {
if (hasRemoteProducers()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ protected void verifyPartitionsNeverCreated(String topicNameStr) throws Exceptio
} catch (Exception ex) {
// If the namespace bundle has not been loaded yet, it means no non-persistent topic was created. So
// this behavior is also correct.
// This error is not expected, a seperated PR is needed to fix this issue.
// This error is not expected, a separated PR is needed to fix this issue.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// This error is not expected, a separated PR is needed to fix this issue.
// This error is not expected, a separate PR is needed to fix this issue.

assertTrue(ex.getMessage().contains("Failed to find ownership for"));
}
}
Expand All @@ -148,7 +148,7 @@ protected void verifyNonPartitionedTopicNeverCreated(String topicNameStr) throws
} catch (Exception ex) {
// If the namespace bundle has not been loaded yet, it means no non-persistent topic was created. So
// this behavior is also correct.
// This error is not expected, a seperated PR is needed to fix this issue.
// This error is not expected, a separated PR is needed to fix this issue.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// This error is not expected, a separated PR is needed to fix this issue.
// This error is not expected, a separate PR is needed to fix this issue.

assertTrue(ex.getMessage().contains("Failed to find ownership for"));
}
}
Expand Down
Loading