[Feature][Connector-V2] Support CDC mode for databend sink connector #9661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Aug 5, 2025
There was a problem hiding this comment.
Thanks @hantmac . Please update the config key according to the relevant JDBC configuration. We try to keep the configuration names with the same meaning consistent. https://github.com/apache/seatunnel/blob/dev/docs/en/connector-v2/sink/Jdbc.md
...rc/main/java/org/apache/seatunnel/connectors/seatunnel/databend/sink/DatabendSinkWriter.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/seatunnel/connectors/seatunnel/databend/config/DatabendOptions.java
Show resolved
Hide resolved
...rc/main/java/org/apache/seatunnel/connectors/seatunnel/databend/sink/DatabendSinkWriter.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/seatunnel/connectors/seatunnel/databend/config/DatabendSinkOptions.java
Outdated
Show resolved
Hide resolved
…pache/seatunnel/connectors/seatunnel/databend/config/DatabendSinkOptions.java Co-authored-by: Jia Fan <[email protected]>
|
hi bro @Hisoka-X , would you like to review this pr? |
|
Hi @hantmac . Could you make sure the ci passed first? Thanks |
Hisoka-X
reviewed
Aug 21, 2025
...main/java/org/apache/seatunnel/connectors/seatunnel/databend/config/DatabendSinkOptions.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/seatunnel/connectors/seatunnel/databend/config/DatabendSinkOptions.java
Outdated
Show resolved
Hide resolved
...bend/src/main/java/org/apache/seatunnel/connectors/seatunnel/databend/sink/DatabendSink.java
Outdated
Show resolved
Hide resolved
...bend/src/main/java/org/apache/seatunnel/connectors/seatunnel/databend/sink/DatabendSink.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/seatunnel/connectors/seatunnel/databend/sink/DatabendSinkWriter.java
Outdated
Show resolved
Hide resolved
...org/apache/seatunnel/connectors/seatunnel/databend/sink/DatabendSinkAggregatedCommitter.java
Outdated
Show resolved
Hide resolved
hantmac
force-pushed
the
feat/databend-sink-cdc
branch
from
b733b14 to
014243b
Compare
Hisoka-X
reviewed
Aug 22, 2025
...org/apache/seatunnel/connectors/seatunnel/databend/sink/DatabendSinkAggregatedCommitter.java
Outdated
Show resolved
Hide resolved
Hisoka-X
changed the title
hantmac
force-pushed
the
feat/databend-sink-cdc
branch
from
a9f1ef7 to
d54cef1
Compare
Hisoka-X
reviewed
Aug 27, 2025
...rc/main/java/org/apache/seatunnel/connectors/seatunnel/databend/sink/DatabendSinkWriter.java
Outdated
Show resolved
Hide resolved
Hisoka-X
reviewed
Aug 30, 2025
...tor-v2-e2e/connector-databend-e2e/src/test/resources/databend/databend_schema_evolution.conf
Show resolved
Hide resolved
...unnel-connector-v2-e2e/connector-databend-e2e/src/test/resources/databend/databend_sink.conf
Show resolved
Hide resolved
Hisoka-X
reviewed
Aug 31, 2025
...onnector-v2-e2e/connector-databend-e2e/src/test/resources/databend/databend_to_databend.conf
Outdated
Show resolved
Hide resolved
|
Hi @hantmac . Overall LGTM, could you rebase on dev to fix some unstable test case? We should make sure all test case passes before merge. |
Of course, thank you for your help! I have rebase on dev. |
|
Please re-trigger the failed ci. |
Hi @Hisoka-X , I have retrigerd this CI https://github.com/hantmac/seatunnel/actions/runs/17457322889/job/49772175066 many times but it always failed, how can I fix it? |
|
Please try rebase on dev. |
Hisoka-X
reviewed
Sep 12, 2025
...bend/src/main/java/org/apache/seatunnel/connectors/seatunnel/databend/sink/DatabendSink.java
Show resolved
Hide resolved
|
waiting test case passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Support the CDC mode for Databend Sink connector according the disscussion in #9615
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add unit tests and e2e tests.
Check list
New License Guide