-
Notifications
You must be signed in to change notification settings - Fork 48
chore: fix compiler warnings #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @guan404ming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on code hygiene by addressing minor compiler warnings. The changes involve marking an unused function parameter with Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes two compiler warnings. The first is an unused parameter, which is addressed by adding the [[maybe_unused]] attribute. The second is an extra semicolon after a macro invocation, which is removed. Both changes are correct and effectively resolve the warnings. I have added one comment with a suggestion for a potential refactoring to further improve code clarity by removing the unused parameter altogether, instead of just marking it as unused.
| void GetMismatchMessageAux(std::ostringstream& os, const AnyView* args, | ||
| [[maybe_unused]] int32_t num_args) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
junrushao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the patch!
|
BTW, there are quite a few |
Sure, I've removed them. Thanks!
The warning is from GCC with -Wpedantic, not MSVC. |
7772c4e to
1f3d8ad
Compare
junrushao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the patch!
Why
num_argsinGetMismatchMessageAuxtemplate functionTVM_FFI_DLL_EXPORT_TYPED_FUNCmacro callHow
[[maybe_unused]]attribute tonum_argsparam