Skip to content

Conversation

@guan404ming
Copy link
Member

Why

  • Unused parameter num_args in GetMismatchMessageAux template function
  • Extra semicolon after TVM_FFI_DLL_EXPORT_TYPED_FUNC macro call

How

  • Add [[maybe_unused]] attribute to num_args param
  • Remove trailing semicolon

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @guan404ming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on code hygiene by addressing minor compiler warnings. The changes involve marking an unused function parameter with [[maybe_unused]] and removing an extraneous semicolon after a macro call. These adjustments improve code quality and reduce compilation noise without altering functionality.

Highlights

  • Unused Parameter Warning: The num_args parameter in the GetMismatchMessageAux template function within include/tvm/ffi/reflection/overload.h has been marked with the [[maybe_unused]] attribute to suppress compiler warnings about its non-usage.
  • Extraneous Semicolon Warning: An unnecessary trailing semicolon after the TVM_FFI_DLL_EXPORT_TYPED_FUNC macro call in tests/cpp/test_function.cc has been removed, resolving a compiler warning.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes two compiler warnings. The first is an unused parameter, which is addressed by adding the [[maybe_unused]] attribute. The second is an extra semicolon after a macro invocation, which is removed. Both changes are correct and effectively resolve the warnings. I have added one comment with a suggestion for a potential refactoring to further improve code clarity by removing the unused parameter altogether, instead of just marking it as unused.

Comment on lines +148 to +149
void GetMismatchMessageAux(std::ostringstream& os, const AnyView* args,
[[maybe_unused]] int32_t num_args) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While [[maybe_unused]] correctly suppresses the compiler warning, a cleaner solution would be to remove the num_args parameter from GetMismatchMessageAux entirely, as it is not used. This would improve code clarity by removing the unneeded parameter and would require updating its call sites.

@guan404ming guan404ming marked this pull request as ready for review January 2, 2026 08:39
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the patch!

@junrushao
Copy link
Member

BTW, there are quite a few TVM_FFI_DLL_EXPORT_TYPED_FUNCs in testing.cc, test_stl.cc, and many other places, do you intend to remove all of them? Does the warnings come from MSVC btw?

@guan404ming
Copy link
Member Author

here are quite a few TVM_FFI_DLL_EXPORT_TYPED_FUNCs in testing.cc, test_stl.cc, and many other places

Sure, I've removed them. Thanks!

Does the warnings come from MSVC btw?

The warning is from GCC with -Wpedantic, not MSVC.

@guan404ming guan404ming force-pushed the fix-compiler-warnings branch from 7772c4e to 1f3d8ad Compare January 2, 2026 09:13
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the patch!

@junrushao junrushao merged commit c22e10e into apache:main Jan 2, 2026
7 checks passed
@guan404ming guan404ming deleted the fix-compiler-warnings branch January 3, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants