Skip to content

chore: fix compiler warnings #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junrushao merged 2 commits into from
Jan 2, 2026
Merged

chore: fix compiler warnings #378

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae753f2
chore: fix compiler warnings
guan404ming Jan 2, 2026
1f3d8ad
chore: remove extra semicolon
guan404ming Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/tvm/ffi/reflection/overload.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ struct TypedOverload : OverloadBase {

private:
template <std::size_t I>
void GetMismatchMessageAux(std::ostringstream& os, const AnyView* args, int32_t num_args) {
void GetMismatchMessageAux(std::ostringstream& os, const AnyView* args,
[[maybe_unused]] int32_t num_args) {
Comment on lines +148 to +149
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While [[maybe_unused]] correctly suppresses the compiler warning, a cleaner solution would be to remove the num_args parameter from GetMismatchMessageAux entirely, as it is not used. This would improve code clarity by removing the unneeded parameter and would require updating its call sites.

if constexpr (I < kNumArgs) {
if (this->last_mismatch_index_ == static_cast<int32_t>(I)) {
TVMFFIAny any_data = args[I].CopyToTVMFFIAny();
Expand Down
2 changes: 1 addition & 1 deletion tests/cpp/test_function.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ TEST(SetRaisedFromCStrParts, TypeError) {

int testing_add1(int x) { return x + 1; }

TVM_FFI_DLL_EXPORT_TYPED_FUNC(testing_add1, testing_add1);
TVM_FFI_DLL_EXPORT_TYPED_FUNC(testing_add1, testing_add1)

TEST(Func, FromExternC) {
// this is the function abi convention
Expand Down