Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Generics in PropertySignatureTable #11527

Merged
merged 7 commits into from
Feb 1, 2024
Merged

Conversation

phryneas
Copy link
Member

PR pair with apollographql/docs#729

@phryneas phryneas requested a review from a team as a code owner January 26, 2024 17:12
Copy link

changeset-bot bot commented Jan 26, 2024

⚠️ No Changeset found

Latest commit: 510fcee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 26, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.15 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 45.97 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 43.5 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 33.88 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.8 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.21 KB (0%)
import { useQuery } from "dist/react/index.js" 5.2 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.27 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.5 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.58 KB (0%)
import { useMutation } from "dist/react/index.js" 3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.73 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.38 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.28 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 3.94 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.75 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.4 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 4.97 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.63 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.04 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 2.98 KB (0%)
import { useFragment } from "dist/react/index.js" 2.18 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.13 KB (0%)

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit d6afe96
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/65b3e805ea546400088e1894
😎 Deploy Preview https://deploy-preview-11527--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 510fcee
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/65badea5abe3f60008ce7192
😎 Deploy Preview https://deploy-preview-11527--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alessbell alessbell requested a review from a team January 29, 2024 14:35
@@ -13,7 +13,7 @@
npm run docmodel
cd ../
rm -rf monodocs
git clone https://github.com/apollographql/docs --branch pr/apidoc-enums-since --single-branch monodocs
git clone https://github.com/apollographql/docs --branch pr/parse-ts --single-branch monodocs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait until the docs PR is merged to update this before merging?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ordering might be a bit weird due to how the data is provided. Merging the docs PR might break this build first.

I think the order should be:

  1. Merge this PR
  2. Merge the docs PR
  3. Create a new PR that updates this branch

I did that yesterday with success, so we'll go ahead and get this merged 🙂

Copy link
Contributor

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@github-actions github-actions bot added the auto-cleanup 🤖 label Jan 31, 2024
@jerelmiller jerelmiller changed the base branch from release-3.9 to main January 31, 2024 23:54
@jerelmiller jerelmiller merged commit ce1ef8b into main Feb 1, 2024
27 checks passed
@jerelmiller jerelmiller deleted the pr/docs-generics branch February 1, 2024 00:15
jerelmiller added a commit that referenced this pull request Feb 1, 2024
jerelmiller added a commit that referenced this pull request Feb 1, 2024
phryneas added a commit that referenced this pull request Feb 1, 2024
phryneas added a commit that referenced this pull request Feb 1, 2024
* Revert "Revert "Replace Generics in PropertySignatureTable (#11527)" (#11549)"

This reverts commit f688036.

* remove log

* switch monodocs build to `main`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants