-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Generics in PropertySignatureTable #11527
Conversation
|
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -13,7 +13,7 @@ | |||
npm run docmodel | |||
cd ../ | |||
rm -rf monodocs | |||
git clone https://github.com/apollographql/docs --branch pr/apidoc-enums-since --single-branch monodocs | |||
git clone https://github.com/apollographql/docs --branch pr/parse-ts --single-branch monodocs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we wait until the docs PR is merged to update this before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the ordering might be a bit weird due to how the data is provided. Merging the docs PR might break this build first.
I think the order should be:
- Merge this PR
- Merge the docs PR
- Create a new PR that updates this branch
I did that yesterday with success, so we'll go ahead and get this merged 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
This reverts commit ce1ef8b.
PR pair with apollographql/docs#729