-
Notifications
You must be signed in to change notification settings - Fork 325
Port compose.directiveArgumentMergeStrategies.test.ts to router
#8311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 19 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
6c559ad
Port test for directiveArgumentMergeStrategies
conwuegb d85bd32
Omit json to simplify test case struct
conwuegb 230b350
Make assert_composition_success() more in line with TS version
conwuegb 98eb302
Run formatter
conwuegb 60ec5b3
Minor comment updates
conwuegb ab98e85
Merge branch 'dev' into conwuegb/fed-686
conwuegb 05d5a99
Move assert_hints_equal() up to mod level
conwuegb a1dc015
Merge branch 'dev' into conwuegb/fed-686
conwuegb 3f6bd3b
Merge branch 'dev' of https://github.com/apollographql/router into co…
conwuegb e4fd7ce
Reset visibility of argument_composition_strategies mod
conwuegb da5c360
fix(composition): Give correct argument name to merger when merging d…
tninesling 21b883f
Update tests to use public-facing directives.
conwuegb d5da1fd
Remove test for mismatched composition strategy and argument type
conwuegb 7c414fa
Add test for nullable_max strategy
conwuegb 36961f6
Add test for nullable_and strategy
conwuegb cf8522d
Add test for nullable_union strategy
conwuegb 5ec1423
Merge branch 'dev' of https://github.com/apollographql/router into co…
conwuegb 25a5ec0
Fix incorrect error code in compose_validation test
conwuegb 5c168b5
Fix incorrect error code in compose_inacessible test
conwuegb 754cb69
Revert change in error code for compose_inaccessible test
conwuegb df90fe2
Merge branch 'dev' of https://github.com/apollographql/router into co…
conwuegb 85da655
Merge branch 'dev' of https://github.com/apollographql/router into co…
conwuegb e7b355e
Check error code before checking error msg
conwuegb db90254
Add useful context to composition errors
conwuegb 081019d
Fix lint errors
conwuegb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.