fix: Cluster-scoped Rollouts should be restricted to user-defined namepaces #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparsai
force-pushed
the
ns-env
branch
2 times, most recently
from
d3518ad
to
ceb5eed
Compare
jparsai
force-pushed
the
ns-env
branch
2 times, most recently
from
85fe53a
to
7d0fb77
Compare
|
Addressed review comments, PTAL. |
…espace Signed-off-by: Jayendra Parsai <[email protected]>
jgwest
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to modify the logic for cluster scoped rollouts controller. Now cluster scoped rollouts controller is allowed in namespaces that are specified in
CLUSTER_SCOPED_ARGO_ROLLOUTS_NAMESPACESenv variable.