Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go version to 1.20 #564

Merged
merged 7 commits into from
Jun 8, 2023
Merged

Conversation

deferraz
Copy link
Contributor

@deferraz deferraz commented May 8, 2023

This PR bumps the golang release to 1.20 as requested by @jannfis in PR #548

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Merging #564 (a665b4f) into master (49825ec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   65.76%   65.76%           
=======================================
  Files          21       21           
  Lines        2039     2039           
=======================================
  Hits         1341     1341           
  Misses        569      569           
  Partials      129      129           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Andre Ferraz added 7 commits May 8, 2023 16:35
@deferraz
Copy link
Contributor Author

deferraz commented Jun 6, 2023

Hi @jannfis , this PR to bump the go release could be approved so we can focus on those two other PRs that you asked for?

Copy link
Contributor

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies please for me taking so long to review and merge this!

LGTM!

@jannfis jannfis merged commit e372237 into argoproj-labs:master Jun 8, 2023
dlactin pushed a commit to dlactin/argocd-image-updater that referenced this pull request May 9, 2024
* bump go version to 1.20

Signed-off-by: Andre Ferraz <[email protected]>

* change golang version in actions to 1.20

Signed-off-by: Andre Ferraz <[email protected]>

* bump golangci-lint-action and setup-go to v3

Signed-off-by: Andre Ferraz <[email protected]>

* change actions/checkout to v3

Signed-off-by: Andre Ferraz <[email protected]>

* bump golangci-lint-action to v1.52.2

Signed-off-by: Andre Ferraz <[email protected]>

* these 3 linters were deprecated in favor of unused

Signed-off-by: Andre Ferraz <[email protected]>

* go linter fix

Signed-off-by: Andre Ferraz <[email protected]>

---------

Signed-off-by: Andre Ferraz <[email protected]>
Co-authored-by: Andre Ferraz <[email protected]>
sribiere-jellysmack pushed a commit to sribiere-jellysmack/argocd-image-updater that referenced this pull request Aug 13, 2024
* bump go version to 1.20

Signed-off-by: Andre Ferraz <[email protected]>

* change golang version in actions to 1.20

Signed-off-by: Andre Ferraz <[email protected]>

* bump golangci-lint-action and setup-go to v3

Signed-off-by: Andre Ferraz <[email protected]>

* change actions/checkout to v3

Signed-off-by: Andre Ferraz <[email protected]>

* bump golangci-lint-action to v1.52.2

Signed-off-by: Andre Ferraz <[email protected]>

* these 3 linters were deprecated in favor of unused

Signed-off-by: Andre Ferraz <[email protected]>

* go linter fix

Signed-off-by: Andre Ferraz <[email protected]>

---------

Signed-off-by: Andre Ferraz <[email protected]>
Co-authored-by: Andre Ferraz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants