-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List applications in all Namespaces when trying to update #831
base: master
Are you sure you want to change the base?
List applications in all Namespaces when trying to update #831
Conversation
Signed-off-by: Sebastien RIBIERE <[email protected]>
Signed-off-by: Sebastien RIBIERE <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #831 +/- ##
==========================================
- Coverage 74.39% 74.29% -0.11%
==========================================
Files 31 31
Lines 3144 3151 +7
==========================================
+ Hits 2339 2341 +2
- Misses 669 674 +5
Partials 136 136 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sebastien RIBIERE <[email protected]>
Let's answer @jannfis ' comment on PR800 Now there is a parameter to chose wether we want namespaced or clusterwide listing. |
Any comments please? |
It looks like I closed PR 800 (I don't remember doing that)
So I Recreated it
For now, AIU only lists application in ArgoCD Namespace before trying to update them
This PR allows AIU to fetch all namespaces for annotated applications