Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Updated logic for role/rolebinding reconciliation #934

Closed
wants to merge 17 commits into from

Conversation

ciiay
Copy link
Collaborator

@ciiay ciiay commented Jun 13, 2023

What type of PR is this?

/kind bug

What does this PR do / why we need it:
gitops-operator 1-083_validate_apps_in_any_namespace test is being flaky.

Which issue(s) this PR fixes:
GITOPS-2874

Fixes #?
1-083_validate_apps_in_any_namespace test

How to test changes / Special notes to the reviewer:
kuttl test sequential/1-083_validate_apps_in_any_namespace shouldn't be flaky or fail anymore.

ciiay and others added 16 commits June 16, 2023 21:51
Signed-off-by: Yi Cai <[email protected]>
* upgrade golangci-lint

Signed-off-by: Jaideep Rao <[email protected]>

* add kuttl test to verify hpa handling behavior

Signed-off-by: Jaideep Rao <[email protected]>

* fix typo in assert file name

Signed-off-by: Jaideep Rao <[email protected]>

---------

Signed-off-by: Jaideep Rao <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
@ciiay
Copy link
Collaborator Author

ciiay commented Jun 17, 2023

Closing this PR as it has mixed commits. Created new PR #939 for same issue.

@ciiay ciiay closed this Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants