Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitops 2874 fix kuttl test 083 #939

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Gitops 2874 fix kuttl test 083 #939

wants to merge 10 commits into from

Commits on Jun 17, 2023

  1. Updated logic for role/rolebinding reconciliation 

    Signed-off-by: Yi Cai <[email protected]>
    @ciiay
    ciiay committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    afef9d8 View commit details
    Browse the repository at this point in the history

  2. Fixed golangci-lint issue 

    Signed-off-by: Yi Cai <[email protected]>
    @ciiay
    ciiay committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    9949a88 View commit details
    Browse the repository at this point in the history

  3. golangci-lint fix 

    Signed-off-by: Yi Cai <[email protected]>
    @ciiay
    ciiay committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    d72f2a7 View commit details
    Browse the repository at this point in the history

  4. refactored reconcileRoleForApplicationSourceNamespaces 

    Signed-off-by: Yi Cai <[email protected]>
    @ciiay
    ciiay committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    2901b9a View commit details
    Browse the repository at this point in the history

  5. Replace context.TODO() with passed ctx 

    Signed-off-by: Yi Cai <[email protected]>
    @ciiay
    ciiay committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    3d776f5 View commit details
    Browse the repository at this point in the history

  6. Updated error log in reconcileRoleForApplicationSourceNamespaces 

    Signed-off-by: Yi Cai <[email protected]>
    @ciiay
    ciiay committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    1a13d15 View commit details
    Browse the repository at this point in the history

  7. Added return err to r.Client.Update 

    Signed-off-by: Yi Cai <[email protected]>
    @ciiay
    ciiay committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    c245440 View commit details
    Browse the repository at this point in the history

  8. Improved logging with more context and revised some func 

    Signed-off-by: Yi Cai <[email protected]>
    @ciiay
    ciiay committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    1c14100 View commit details
    Browse the repository at this point in the history

  9. Refactored function for debugging 

    Signed-off-by: Yi Cai <[email protected]>
    @ciiay
    ciiay committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    32ac431 View commit details
    Browse the repository at this point in the history

  10. Added comments 

    Signed-off-by: Yi Cai <[email protected]>
    @ciiay
    ciiay committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    75e61c1 View commit details
    Browse the repository at this point in the history