Gitops 2874 fix kuttl test 083 #939
Open
+303
−259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
gitops-operator 1-083_validate_apps_in_any_namespace test is being flaky.
Which issue(s) this PR fixes:
GITOPS-2874
Fixes #?
1-083_validate_apps_in_any_namespace test
How to test changes / Special notes to the reviewer:
kuttl test sequential/1-083_validate_apps_in_any_namespace shouldn't be flaky or fail anymore.
Main changes are in
controllers/argocd/util.go
andcontrollers/argocd/role.go
.In
controllers/argocd/util.go
,namespaceFilterPredicate
into smaller functions so it’s easier to read.In
controllers/argocd/role.go
,role[]
in reconcileRole function