-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passed authentication params on init #41
Allow passed authentication params on init #41
Conversation
Signed-off-by: kaosx5s <>
Signed-off-by: kaosx5s <>
Signed-off-by: kaosx5s <>
343ad4c
to
a099d6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's be consistent with the options we provide, if we want to allow passing credentials via constructor parameters, let's allow all of them.
Then we can do something like:
def __ init__(self, username=None, password=None, token=None):
username = os.environment.get('GITHUB_USERNAME', username)
password = os.environment.get('GITHUB_PASSWORD', password)
token = os.environment.get('GITHUB_TOKEN', token)
...
# Check for credentials
# Instantiate the client
Signed-off-by: kaosx5s <>
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 77.64% 81.13% +3.49%
==========================================
Files 11 11
Lines 492 493 +1
Branches 73 77 +4
==========================================
+ Hits 382 400 +18
+ Misses 96 76 -20
- Partials 14 17 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AgarFu need you to approve changes. |
Description
Thanks for contributing this Pull Request. Make sure that you send in this Pull Request to the
master
branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.Relevant Issues :
What Changed and Why? :
Type of change :
Other: