Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure when alternatebackends is empty, canary weight should be 0 #12

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/fixtures/route/route.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@ func HaveWeights(stableWeight, canaryWeight int32) matcher.GomegaMatcher {
return false
}

if len(route.Spec.AlternateBackends) == 1 && *route.Spec.AlternateBackends[0].Weight != canaryWeight {
if len(route.Spec.AlternateBackends) == 0 && canaryWeight != 0 {
// If alternate backend is empty, that is equivalent to a canary weight of 0, so we verify here that canary weight is 0.
fmt.Printf("Canary weight mismatch: got %d, want %d\n", 0, canaryWeight)
return false

} else if len(route.Spec.AlternateBackends) == 1 && *route.Spec.AlternateBackends[0].Weight != canaryWeight {
fmt.Printf("Canary weight mismatch: got %d, want %d\n", *route.Spec.AlternateBackends[0].Weight, canaryWeight)
return false
}
Expand Down
Loading