Ensure when alternatebackends is empty, canary weight should be 0 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan West <[email protected]>
jgwest
force-pushed
the
add-alternate-role-test-check-april-2024
branch
from
d8818e1
to
ad4ab7d
Compare
chetan-rns
approved these changes
Jul 25, 2024
|
Thanks @chetan-rns! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix to one of the E2E tests:
.spec.alternatebackendsis empty, this means that the canary will be receiving no traffic. This is equivalent to canary weight of 0..spec.alternateBackendsis empty, that the canary weight is 0.We don't currently have E2E tests running as part of PRs in this repo, but I have manually run the E2E test to verify it works as expected.