Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Make acceptance tests happy again #439

Merged
merged 1 commit into from
Oct 3, 2024
Merged

test: Make acceptance tests happy again #439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/provider/data_source_application_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ func TestAccArgoCDApplicationDataSource(t *testing.T) {
ExternalProviders: map[string]resource.ExternalProvider{
"argocd": {
VersionConstraint: "~> 5.0",
Copy link
Collaborator

@blakepettersson blakepettersson Oct 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the VersionConstraint be "~> 6.2.0" (or even "~> 7.0")?

Copy link
Collaborator Author

@mkilchhofer mkilchhofer Oct 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not want to touch any functionality/testing logic yet. Unsure why we had ~> 5.0 here. Maybe we should completely remove the version constriant?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a follow-up issue for this:

Source: "oboukili/argocd",
Source: "argoproj-labs/argocd",
},
},
Config: `
Expand Down Expand Up @@ -214,7 +214,7 @@ func TestAccArgoCDApplicationDataSource_Directory(t *testing.T) {
ExternalProviders: map[string]resource.ExternalProvider{
"argocd": {
VersionConstraint: "~> 5.0",
Source: "oboukili/argocd",
Source: "argoproj-labs/argocd",
},
},
Config: `
Expand Down Expand Up @@ -322,7 +322,7 @@ ingress:
ExternalProviders: map[string]resource.ExternalProvider{
"argocd": {
VersionConstraint: "~> 5.0",
Source: "oboukili/argocd",
Source: "argoproj-labs/argocd",
},
},
Config: fmt.Sprintf(`
Expand Down Expand Up @@ -432,7 +432,7 @@ func TestAccArgoCDApplicationDataSource_Kustomize(t *testing.T) {
ExternalProviders: map[string]resource.ExternalProvider{
"argocd": {
VersionConstraint: "~> 5.0",
Source: "oboukili/argocd",
Source: "argoproj-labs/argocd",
},
},
Config: `
Expand Down