Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(navigation): invalid redirection #565

Closed
wants to merge 2 commits into from

Conversation

KSH-code
Copy link

@KSH-code KSH-code commented Jun 12, 2024

fix #564

When I discover applications on like https://argocd.com/service/applications/, search applications and then click it.
But it is redirected to https://argocd.com/service/applications//{application-name}.
And an empty page is shown.

for the soultion, the slash in the end has to be removed.

@KSH-code KSH-code changed the title Fix invalid redirection fix(navigation) invalid redirection Jun 12, 2024
@KSH-code KSH-code changed the title fix(navigation) invalid redirection fix(navigation): invalid redirection Jun 12, 2024
@KSH-code
Copy link
Author

KSH-code commented Jun 21, 2024

Hi @agilgur5
Could you please give me feedback about this pr for merging?
Thanks!

@agilgur5
Copy link
Contributor

I can take a look, but I'm not a CD Maintainer so I wouldn't merge on my own in any case. It would be good to link to an issue upstream as well per #453

@KSH-code
Copy link
Author

KSH-code commented Jul 17, 2024

Thank you for your check.
I've made an issue on argoproj/argo-cd#19093 which includes referring this.

@agilgur5
Copy link
Contributor

I left a comment on your upstream issue; this is perhaps better addressed upstream than here: argoproj/argo-cd#19093 (comment)

@KSH-code
Copy link
Author

I agree. I close this so that I will address this issue on upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation error with location.href ends with /
2 participants