Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github): Add checkrun support #223

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

davhdavh
Copy link

  • Cleans up the github code so that each new template-supported prop only takes a single line (instead of 10+)
  • Add support for CheckRuns
  • Add a bit of documentation for all of the supported APIs

Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
@davhdavh
Copy link
Author

davhdavh commented Sep 28, 2023

That linter is really annoying, could it not just give ALL of the errors in 1 run, instead of taking 8...

anyway, how to solve the last one?

  Error: composites: github.com/google/go-github/v41/github.Timestamp struct literal uses unkeyed fields (govet)

Signed-off-by: Dennis Haney <[email protected]>
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (a8d185e) 55.13% compared to head (ae1870f) 54.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   55.13%   54.74%   -0.40%     
==========================================
  Files          35       35              
  Lines        3337     3352      +15     
==========================================
- Hits         1840     1835       -5     
- Misses       1230     1263      +33     
+ Partials      267      254      -13     
Files Coverage Δ
pkg/services/github.go 32.05% <39.34%> (-3.61%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Dennis Haney <[email protected]>
@davhdavh
Copy link
Author

There is no existing tests for the api calls, so I have no idea how to make test for the new api call.

Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Signed-off-by: Dennis Haney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant