Skip to content

fix: resolve Sonar findings and security violations - #40

Merged
arnabnandy7 merged 1 commit into
mainfrom
ci/sonarFailure
Aug 20, 2026
Merged

arnabnandy7 merged 1 commit into
mainfrom
ci/sonarFailure

Conversation

@arnabnandy7

Copy link
Copy Markdown
Owner

Summary

Resolves the SonarCloud maintainability findings and workflow security violations.

Changes

  • Pin actions/checkout to an immutable commit SHA.
  • Prevent lifecycle scripts during CI dependency installation with npm ci --ignore-scripts.
  • Replace waitFor and getByRole with findByRole.
  • Extract nested quality-badge ternary logic.
  • Mark React component props as read-only.
  • Use String.raw for escaped backslash handling.
  • Remove the redundant null union with unknown.

Verification

  • Full test suite: 38 tests passed.

@arnabnandy7 arnabnandy7 self-assigned this Aug 20, 2026
@vercel

vercel Bot commented Aug 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openissue-dev Ready Ready Preview Aug 20, 2026 8:12am

@arnabnandy7 arnabnandy7 added bug Something isn't working javascript Pull requests that update javascript code ci test labels Aug 20, 2026
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
@sonarqubecloud

Copy link
Copy Markdown

@arnabnandy7
arnabnandy7 merged commit e567cd0 into main Aug 20, 2026
6 checks passed

This branch was successfully deployed

1 active deployment
Preview — 54968cf5 Deployed Aug 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci javascript Pull requests that update javascript code test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant