-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
67 emissivity #86
67 emissivity #86
Conversation
Do we need the possibility to have multiple value pairs of temperature and emissivity? In this implementation, only two fixed values are possible. |
It gives the possibility to add your own emissivity data. |
A further problem of the table given in the legacy for emissivity is, that the value is not fixed for all materials but includes ranges. |
Group decision: No lookup table with temperature, angle and wavelength for now. This could be added in a later release. |
We use the hemispherical total emissivity which considers full emission over all wavelengths, directions and polarization for a given particular temperature: ε(T) |
Could you add that to the description? |
Added the material property of emissivity to the material_schema.json as an optional property (not required) Signed-off-by: [email protected] <[email protected]>
Added the material property of emissivity to the example_material.xomp Signed-off-by: [email protected] <[email protected]>
include "emissivity_data" with separated emissivity value Signed-off-by: [email protected] <[email protected]>
add emissivity data Signed-off-by: [email protected] <[email protected]>
Signed-off-by: ritter <[email protected]> Signed-off-by: [email protected] <[email protected]>
27b37cd
to
fa900f0
Compare
Signed-off-by: DavidJRitter904 <[email protected]>
@DavidJRitter904 something went wrong with your last commit. There are no changes anymore in this PR. |
Signed-off-by: David Ritter <[email protected]>
Signed-off-by: DavidJRitter904 <[email protected]>
@ClemensLinnhoff I have updated again the branch and resolved the new merge conflicts. |
@ClemensLinnhoff with Emissive materials, a custom shader (or modifications to a simulator's 'standard' shader) will be required for this to look correct. Also additional textures, point/spot lights will be required as well. Is this outside of our scope? |
This is not about conventional light sources. This is about thermal radiation. |
examples/example_material.xomp
Outdated
@@ -15,6 +15,11 @@ | |||
"surface_height_rms": 0.8, | |||
"surface_correlation_length": 1.0 | |||
}, | |||
"emissivity_data": { | |||
"emissivity": 0.07, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"emissivity": 0.07, | |
"emissivity_coefficient": 0.07, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was discussed in the material group, that emissivity_coefficient would be a bit more accurate.
schemas/material_schema.json
Outdated
"type": "object", | ||
"description": "Emissivity data of the material", | ||
"properties": { | ||
"emissivity": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"emissivity": { | |
"emissivity_coefficient": { |
I just want to confirm that this "emmisivity" is for the far infrared rays sensor, right? |
Needs to be adapted to new naming convention, after #110 is merged, |
Mainly for infrared cameras. |
Signed-off-by: David Ritter <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Signed-off-by: ClemensLinnhoff <[email protected]>
Describe your changes
As discussed in Meeting 04.09.2024:
Some questions to ask:
Issue ticket number and link
Closes issue #67.
Mention a member
Add @mentions of the person or team responsible for reviewing the proposed changes.
Checklist before requesting a review