Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

67 emissivity #86

Merged
merged 11 commits into from
Sep 24, 2024
Merged

67 emissivity #86

merged 11 commits into from
Sep 24, 2024

Conversation

DavidJRitter904
Copy link
Contributor

@DavidJRitter904 DavidJRitter904 commented Sep 5, 2024

Describe your changes

As discussed in Meeting 04.09.2024:

  • Add emissivity data as object type with separated emissivity and temperature values.

Some questions to ask:

  • What is the change?
  • What does it fix?
  • Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
  • How has it been tested?

Issue ticket number and link

Closes issue #67.

Mention a member

Add @mentions of the person or team responsible for reviewing the proposed changes.

Checklist before requesting a review

  • I have performed a self-review of my code/documentation.
  • My changes generate no new warnings during the documentation generation.

@DavidJRitter904 DavidJRitter904 added isState:New A new issue that needs to be classified to a type. isType:Feature An issue that adds new features to the project. isSubGroup:MATERIAL labels Sep 5, 2024
@DavidJRitter904 DavidJRitter904 marked this pull request as ready for review September 5, 2024 11:15
@ClemensLinnhoff
Copy link
Collaborator

Do we need the possibility to have multiple value pairs of temperature and emissivity? In this implementation, only two fixed values are possible.

@DavidJRitter904
Copy link
Contributor Author

Do we need the possibility to have multiple value pairs of temperature and emissivity? In this implementation, only two fixed values are possible.

It gives the possibility to add your own emissivity data.
We would anyway provide the table as in the legacy branch at T=300.0 K with a fixed emissivity value then.

@DavidJRitter904
Copy link
Contributor Author

A further problem of the table given in the legacy for emissivity is, that the value is not fixed for all materials but includes ranges.

Legacy emissivity table

@ClemensLinnhoff
Copy link
Collaborator

Do we need the possibility to have multiple value pairs of temperature and emissivity? In this implementation, only two fixed values are possible.

Group decision: No lookup table with temperature, angle and wavelength for now. This could be added in a later release.

@ipg-jsc ipg-jsc mentioned this pull request Sep 12, 2024
4 tasks
@DavidJRitter904
Copy link
Contributor Author

We use the hemispherical total emissivity which considers full emission over all wavelengths, directions and polarization for a given particular temperature:   ε(T)

@ClemensLinnhoff
Copy link
Collaborator

We use the hemispherical total emissivity which considers full emission over all wavelengths, directions and polarization for a given particular temperature:   ε(T)

Could you add that to the description?
And please also add the source field analog to #82.

DavidJRitter904 and others added 5 commits September 12, 2024 15:59
Added the material property of emissivity to the material_schema.json as an optional property (not required)

Signed-off-by: [email protected] <[email protected]>
Added the material property of emissivity to the example_material.xomp

Signed-off-by: [email protected] <[email protected]>
include "emissivity_data" with separated emissivity value

Signed-off-by: [email protected] <[email protected]>
Signed-off-by: DavidJRitter904 <[email protected]>
@ClemensLinnhoff
Copy link
Collaborator

@DavidJRitter904 something went wrong with your last commit. There are no changes anymore in this PR.

@DavidJRitter904
Copy link
Contributor Author

@ClemensLinnhoff I have updated again the branch and resolved the new merge conflicts.
The emissivity data should be here now, including the elasticity and density data already pulled from the main. 👍

@drsftx73
Copy link

@ClemensLinnhoff with Emissive materials, a custom shader (or modifications to a simulator's 'standard' shader) will be required for this to look correct. Also additional textures, point/spot lights will be required as well. Is this outside of our scope?

@ClemensLinnhoff
Copy link
Collaborator

@ClemensLinnhoff with Emissive materials, a custom shader (or modifications to a simulator's 'standard' shader) will be required for this to look correct. Also additional textures, point/spot lights will be required as well. Is this outside of our scope?

This is not about conventional light sources. This is about thermal radiation.

@@ -15,6 +15,11 @@
"surface_height_rms": 0.8,
"surface_correlation_length": 1.0
},
"emissivity_data": {
"emissivity": 0.07,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"emissivity": 0.07,
"emissivity_coefficient": 0.07,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was discussed in the material group, that emissivity_coefficient would be a bit more accurate.

"type": "object",
"description": "Emissivity data of the material",
"properties": {
"emissivity": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"emissivity": {
"emissivity_coefficient": {

@KimuraDIVP
Copy link

I just want to confirm that this "emmisivity" is for the far infrared rays sensor, right?

@ClemensLinnhoff
Copy link
Collaborator

Needs to be adapted to new naming convention, after #110 is merged,

@ClemensLinnhoff
Copy link
Collaborator

I just want to confirm that this "emmisivity" is for the far infrared rays sensor, right?

Mainly for infrared cameras.

@ClemensLinnhoff ClemensLinnhoff merged commit 7cfa4ed into main Sep 24, 2024
2 checks passed
@ClemensLinnhoff ClemensLinnhoff deleted the 67-emissivity branch September 24, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
isState:New A new issue that needs to be classified to a type. isSubGroup:MATERIAL isType:Feature An issue that adds new features to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants