-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
67 emissivity #86
Merged
Merged
67 emissivity #86
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6c8b26b
Update material_schema.json for emissivity
DavidJRitter904 3d6e8e1
Update example_material.xomp
DavidJRitter904 b8ec59f
Update material_schema.json for emissivity
DavidJRitter904 d33e85d
Update example_material.xomp for emissivity
DavidJRitter904 fa900f0
Update emissivity description, add source fields
45eb969
Resolve merge conflict
DavidJRitter904 02b593d
Update emissivity data after resolving merge conflict
DavidJRitter904 87092f9
Update branch, resolve merge conflicts
DavidJRitter904 d3c018a
Update emissivity naming + camelCase as in PR #110
DavidJRitter904 5eaec0c
Merge branch 'main' into 67-emissivity
ClemensLinnhoff 395d969
Fix remaining merge conflict
ClemensLinnhoff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -82,6 +82,29 @@ | |||||
"surface_correlation_length" | ||||||
] | ||||||
}, | ||||||
"emissivity_data": { | ||||||
"type": "object", | ||||||
"description": "Emissivity data of the material", | ||||||
"properties": { | ||||||
"emissivity": { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
"type": "number", | ||||||
"description": "Emissivity describes the ability to emit energy as thermal radiation. Given as the fraction of thermal radiation emitted by a surface relative to the radiation emitted by an ideal black body at the same temperature. Here the hemispherical total emissivity is used which considers full emission over all wavelengths, directions and polarization for a given particular temperature: ε(T)" | ||||||
}, | ||||||
"temperature": { | ||||||
"type": "number", | ||||||
"description": "Temperature in Kelvin [K] at which the emissivity is measured" | ||||||
}, | ||||||
"source": { | ||||||
"type": "string", | ||||||
"description": "Source of the emissivity data." | ||||||
} | ||||||
}, | ||||||
"required": [ | ||||||
"emissivity", | ||||||
"temperature", | ||||||
"source" | ||||||
] | ||||||
}, | ||||||
"elasticity_data": { | ||||||
"type": "object", | ||||||
"description": "Information about the elasticity of the material.", | ||||||
|
@@ -141,4 +164,4 @@ | |||||
"metadata", | ||||||
"materials_properties" | ||||||
] | ||||||
} | ||||||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was discussed in the material group, that emissivity_coefficient would be a bit more accurate.