-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging output to file functionality #11762
Open
Choudhry18
wants to merge
17
commits into
astral-sh:main
Choose a base branch
from
Choudhry18:cli_logs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making fork up to date
Merging main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This would introduce the ability to log traces to a log file for a user to view later - closes #9850 .
Test Plan
I have done manual testing to check the log file against the trace output on terminal. I have also added some snap shot tests to ensure the
--log
invocation and the subsequent "See <log_file> for details" message behaves as intended.Requirements Discussion
There are some requirements and implementation details that need to be discussed as they depend on users would want to use this. As a lot of people who would use this feature are contributors, trying to log while testing it would great to get their input on how they would like to use this. I have added comments that start with "Discuss" to indicate these but here are some things that need to be discussed:
tracing
crate (current)RUST_LOG
for file logs, currently they are determined the count of--log_verbose
flag ranging from 0 to 3--log
is set or only on errors and failure exits.