Skip to content

Add skills for authoring tasks with Java SDK#234

Merged
jason810496 merged 5 commits into
mainfrom
java-sdk-authoring-skill
Jul 16, 2026
Merged

Add skills for authoring tasks with Java SDK#234
jason810496 merged 5 commits into
mainfrom
java-sdk-authoring-skill

Conversation

@uranusjr

Copy link
Copy Markdown
Member

These are for AIP-108, which will be released with Airflow 3.3. We also plan to add skills for Go SDK, so the skills here are structured specifically to avoid duplication across SDKs.

These are for AIP-108, which will be released with Airflow 3.3. We also
plan to add skills for Go SDK, so the skills here are structured
specifically to avoid duplication across SDKs.
@jason810496
jason810496 self-requested a review July 1, 2026 03:21

@kaxil kaxil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in good shape, and notably self-contained: every cross-reference resolves. The four new skills point at each other and at authoring-dags / deploying-airflow / setting-up-astro-project, all of which are already on main. That's the right pattern, and worth calling out because the Go side (#239) references authoring-language-sdk-tasks and the shared config file that only exist in this PR, so those links dangle on main until this merges.

The version hygiene is good too: ${version} placeholders, the -SNAPSHOT/preview note, and the "read the generated Dockerfile, don't pin from memory" hedge all keep it from going stale. For contrast, #239's deploy skill hardcodes apache/airflow:3.3.0 and a @v1.0.0 pin that doesn't resolve, so it could borrow this approach.

The one thing to coordinate is the shared file. This PR and #239 both add skills/configuring-airflow-language-sdks/SKILL.md, and #239's version is a Go-inclusive superset of this Java-framed one. Since this PR is the foundation the Go skills build on, the cleanest path is to land this first and have #239 rebase its copy into a MODIFY that adds the Go coordinator. Noted inline.

Two minor consistency points: the descriptions open imperative (Write / Configure / Build and deploy) where the post-#237 catalog settled on third-person-present (Writes / Configures / Builds and deploys), and the prose uses Dag/Dags while the rest of the catalog uses DAG. Both are consistency nits rather than rules.

Comment thread skills/deploying-java-sdk-bundles/SKILL.md
jason810496 added a commit that referenced this pull request Jul 10, 2026
Now that the merge order is reversed (Go lands before Java), this PR
carries the shared foundation and references no unmerged Java skills:

- Duplicate authoring-language-sdk-tasks from #234, framed with the Go
  SDK as the concrete example (includes the stub pitfalls: empty-body
  AST check, retry_policy rejection).
- Slice configuring-airflow-language-sdks down to the shared wiring plus
  ExecutableCoordinator; #234 re-adds JavaCoordinator as a MODIFY after
  rebasing. Port the wording/convention improvements from #234.
- Match catalog conventions in the Go skills: third-person descriptions,
  DAG capitalization in prose.
# Conflicts:
#	skills/authoring-language-sdk-tasks/SKILL.md
#	skills/configuring-airflow-language-sdks/SKILL.md
@jason810496
jason810496 merged commit 5432198 into main Jul 16, 2026
5 checks passed
@jason810496
jason810496 deleted the java-sdk-authoring-skill branch July 16, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants