Add Go-SDK Agent Skills#239
Conversation
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
These are well put together. The three-way split reads cleanly, the AFBNDL01 packing model comes across clearly, and the dependency-injection-by-type table plus the pitfalls/troubleshooting sections put the failure modes where a reader will hit them. Names, body lengths, and description lengths are all in good shape.
Both of the blocking issues trace back to #234. This PR adds skills/configuring-airflow-language-sdks/SKILL.md, and #234 adds a file at that same path with different content (Java-framed there, Go-inclusive here), so whichever merges second will conflict or overwrite the other. Several references here also point at skills that live only in #234 (authoring-language-sdk-tasks, the "read this first" foundation, plus authoring-java-sdk-tasks and deploying-java-sdk-bundles), so on main those links dangle. That is the same dead-cross-reference problem #237 set out to fix, whose stated check was that every cross-referenced skill resolves. Landing this after #234 (or together) and re-running that check against the combined tree clears both.
Lower-priority items, also noted inline: the @v1.0.0 pin won't resolve and reads as stable against the skill's own preview framing; the prose uses Dag/Dags while the rest of the catalog uses DAG; and the descriptions open imperative (Write/Configure/Build) where the post-#237 catalog settled on third-person-present (Writes/Configures/Builds), which is a consistency point rather than a rule. The trigger lists could also name a case or two where each skill should not fire, to cut misfires on generic "queue" questions.
Now that the merge order is reversed (Go lands before Java), this PR carries the shared foundation and references no unmerged Java skills: - Duplicate authoring-language-sdk-tasks from #234, framed with the Go SDK as the concrete example (includes the stub pitfalls: empty-body AST check, retry_policy rejection). - Slice configuring-airflow-language-sdks down to the shared wiring plus ExecutableCoordinator; #234 re-adds JavaCoordinator as a MODIFY after rebasing. Port the wording/convention improvements from #234. - Match catalog conventions in the Go skills: third-person descriptions, DAG capitalization in prose.
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Hi @uranusjr, I just duplicated the common part in Java-SDK one here, so that we can merge this first as we discussed (Go-SDK already released, we're still waiting for Java-SDK in the mean time).
Would you mind to take a final look before merge? Thanks.
3 participants
Same as #234 targeting for AIP-108 with 3.3.0 but focus on Go-SDK side.