Skip to content

Conversation

@jonesmg
Copy link

@jonesmg jonesmg commented Oct 21, 2025

For unbound objects on hyperbolic orbits e > 1.

The format for the perihelion time for comets was listed as a string, but MOST actually requires the time as a Julian Date (float). If you provide a string here the query will fail.

For unbound objects on hyperbolic orbits e > 1. 

The format for the perihelion time for comets was listed as a string, but MOST actually requires the time as a Julian Date (float). If you provide a string here the query will fail.
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.72%. Comparing base (b4ccef0) to head (478da5b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3444   +/-   ##
=======================================
  Coverage   70.72%   70.72%           
=======================================
  Files         232      232           
  Lines       20041    20041           
=======================================
  Hits        14174    14174           
  Misses       5867     5867           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides making the docs consistent for both methods and the narrative docs; I wonder if this should be fixed in code and in fact we could accept an astropy Time object or a string that can be parsed into an astropy Time?

(The code fixes are definitely beyond the scope here, but could be reported in a separate issue)

Comment on lines +481 to +482
perih_time : float or None
Perihelion time (JD).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perih_time is also a parameter for query_image; is this an issue there, too?

And it is also mentioned in the narrative docs file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I missed that. It should JD as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through all the parameters and found a few other errors. I fixed all that I found. 0497d52

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update these in the narrative docs file? docs/ipac/irsa/most.rst

@jonesmg
Copy link
Author

jonesmg commented Oct 24, 2025

I think the formats for the manual input option in MOST were set so that it's easy to copy-paste the the orbital parameters from the Minor Planets Center (e.g., https://data.minorplanetcenter.net/db_search/show_object?utf8=%E2%9C%93&object_id=2I). So I don't think switching the date format would improve usability, unless there were also a plan to set up functionality to query the MPC database from astroquery as well.

@jonesmg
Copy link
Author

jonesmg commented Oct 24, 2025

I now see that there is already an MPC module, so maybe this could be a future goal to make these two talk to each other in a convenient way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants