Skip to content

Fix docstring for eccentricity and perihelion time #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix docstring for eccentricity and perihelion time #3444

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d61679c
Fix docstring for eccentricity and perihelion time
jonesmg Oct 21, 2025
0497d52
Further corrections to docstring parameter definitions.
jonesmg Oct 24, 2025
2ed5cb7
Merged main.
jonesmg Oct 24, 2025
c60c7b2
Corrected epoch parameter definition.
jonesmg Oct 24, 2025
478da5b
Update parameter definitions in MOST docs.
jonesmg Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions astroquery/ipac/irsa/most.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ def query_object(self, catalog="wise_merge", input_mode="name_input", output_mod
Epoch in MJD.
Required when input mode is ``"manual_input"``.
eccentricity : float or None
Eccentricity (0-1).
Eccentricity (>0).
Required when input mode is ``"manual_input"``.
inclination : float or None
Inclination (0-180 degrees).
Expand All @@ -478,8 +478,8 @@ def query_object(self, catalog="wise_merge", input_mode="name_input", output_mod
Perihelion distance (AU).
Required when input mode is ``"manual_input"`` and object type is
``"Comet"``.
perih_time : str or None
Perihelion time (YYYY+MM+DD+HH:MM:SS).
perih_time : float or None
Perihelion time (JD).
Comment on lines +481 to +482
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perih_time is also a parameter for query_image; is this an issue there, too?

And it is also mentioned in the narrative docs file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I missed that. It should JD as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through all the parameters and found a few other errors. I fixed all that I found. 0497d52

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update these in the narrative docs file? docs/ipac/irsa/most.rst

Required when input mode is ``"manual_input"`` and object type is
``"Comet"``.
get_query_payload : bool
Expand Down
Loading