Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optional dependency issue #190

Merged
merged 25 commits into from
Mar 15, 2024
Merged

fix: optional dependency issue #190

merged 25 commits into from
Mar 15, 2024

Conversation

zahid-syed
Copy link
Contributor

No description provided.

@zahid-syed zahid-syed self-assigned this Mar 9, 2024
@zahid-syed zahid-syed marked this pull request as ready for review March 11, 2024 15:58
@jamescalam jamescalam changed the title optional dependency issue fix started fix: optional dependency issue Mar 11, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.95%. Comparing base (19cf5d2) to head (314005d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
+ Coverage   77.72%   77.95%   +0.22%     
==========================================
  Files          42       42              
  Lines        2092     2118      +26     
==========================================
+ Hits         1626     1651      +25     
- Misses        466      467       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

semantic_router/llms/mistral.py Outdated Show resolved Hide resolved
semantic_router/llms/llamacpp.py Outdated Show resolved Hide resolved
semantic_router/llms/llamacpp.py Outdated Show resolved Hide resolved
semantic_router/encoders/mistral.py Outdated Show resolved Hide resolved
semantic_router/encoders/mistral.py Outdated Show resolved Hide resolved
semantic_router/encoders/mistral.py Outdated Show resolved Hide resolved
semantic_router/encoders/mistral.py Outdated Show resolved Hide resolved
semantic_router/encoders/mistral.py Outdated Show resolved Hide resolved
semantic_router/encoders/mistral.py Outdated Show resolved Hide resolved
semantic_router/encoders/mistral.py Outdated Show resolved Hide resolved
@ashraq1455 ashraq1455 self-requested a review March 14, 2024 18:28
Copy link
Contributor

@ashraq1455 ashraq1455 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lg

Copy link
Member

@jamescalam jamescalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @zahid-syed, great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants