provider//passt: add changes for multiarch #5361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitterl
force-pushed
the
passt_provider
branch
from
1a39859 to
ae4067e
Compare
smitterl
changed the title
smitterl
changed the title
smitterl
force-pushed
the
passt_provider
branch
from
ae4067e to
a724ded
Compare
|
@yalzhang please help review |
smitterl
force-pushed
the
passt_provider
branch
from
a724ded to
4114363
Compare
yalzhang
approved these changes
Dec 25, 2023
smitterl
force-pushed
the
passt_provider
branch
from
4114363 to
a729ef8
Compare
smitterl
force-pushed
the
passt_provider
branch
from
a729ef8 to
922cf4f
Compare
'passt.avx2' is a specialization only for x86_64. On other architectures the process might just be "passt". Change the regular expression to match any process containing "passt". `check_vm_ip` calculated the guest interface name for x86_64 for other architectures allow for configuration of this value. Remove zone index when comparing routes as they might differ between host and guest (e.g. if the interfaces are named differently). Check gateways by confirming that routes in guest are available on host instead of confirming they must be exactly the same on both ends. Pass the target interface name to the check_connection function to allow for the correct selection of the gateway. When a host has two interfaces the function used a list and failed. `check_protocol_connection` sent a command to start listening to the server VM and the client send a message to quickly. We could establish a wait condition like checking ports of the machine but a static sleep seemed like a simpler and still reliable solution. The port list definition for `check_portforward` needs to contain the host interface, not the VM interface. Therefore, pass the parameter and remove the unused vm_iface. Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
passt_provider
branch
from
922cf4f to
de9e701
Compare
chloerh
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on avocado-framework/avocado-vt#3818
'passt.avx2' is a specialization only for x86_64.
On other architectures the process might just be "passt".
Change the regular expression to match any process containing
"passt".
check_vm_ipcalculated the guest interface name for x86_64for other architectures allow for configuration of this value.
Remove zone index when comparing routes as they might differ
between host and guest (e.g. if the interfaces are named differently).
Check gateways by confirming that routes in guest are available on
host instead of confirming they must be exactly the same on both ends.
Pass the target interface name to the check_connection function to
allow for the correct selection of the gateway. When a host
has two interfaces the function used a list and failed.
check_protocol_connectionsent a command to start listening tothe server VM and the client send a message to quickly. We could
establish a wait condition like checking ports of the machine
but a static sleep seemed like a simpler and still reliable solution.
The port list definition for
check_portforwardneeds to containthe host interface, not the VM interface. Therefore, pass the parameter
and remove the unused vm_iface.