Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dummy_infrastructure): fix bugprone-reserved-identifier #9919

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

mitsudome-r
Copy link
Member

Description

This is a duplicate of #9727.
I recreated it since the original author finished contract with TIER IV and couldn't sync the PR with the latest main to pass CI.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 15, 2025
Signed-off-by: kobayu858 <[email protected]>
@mitsudome-r
Copy link
Member Author

Since the original PR was already approved, I will merge this once the required CIs pass.

@mitsudome-r mitsudome-r added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.49%. Comparing base (951b1df) to head (3b0638c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9919      +/-   ##
==========================================
- Coverage   30.60%   29.49%   -1.12%     
==========================================
  Files        1362     1444      +82     
  Lines      104178   108702    +4524     
  Branches    41517    42492     +975     
==========================================
+ Hits        31885    32059     +174     
- Misses      69217    73550    +4333     
- Partials     3076     3093      +17     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 29.49% <ø> (-1.12%) ⬇️ Carriedforward from 951b1df

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r mitsudome-r merged commit 557a71e into autowarefoundation:main Jan 15, 2025
42 checks passed
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants