[ci] Migrate reexec tasks to a script to simplify maintenance #4761

maru-ava · 2025-12-17T17:31:12Z

Why this should be merged

Doing anything non-trivial in tasks is not recommended. This change moves the reexec logic to a new script for ease of maintenance and to simplify usage.

How this was tested

CI

Need to be documented in RELEASES.md?

N/A

maru-ava · 2025-12-17T17:31:41Z

.github/actions/c-chain-reexecution-benchmark/action.yml

    description: 'The password for the Prometheus instance.'
    required: true
    default: ''
-  workspace:


I noticed this was unused.

maru-ava · 2025-12-17T17:32:29Z

.github/actions/c-chain-reexecution-benchmark/action.yml

        role-to-assume: ${{ inputs.aws-role }}
        aws-region: ${{ inputs.aws-region }}
        role-duration-seconds: ${{ inputs.aws-role-duration-seconds }}
-    - name: Validate inputs


Validation moved to the script so its defined once for use locally and in CI and it can be subject to shellcheck linting.

maru-ava · 2025-12-17T17:32:46Z

.github/actions/c-chain-reexecution-benchmark/action.yml

+      run: echo "BENCHMARK_OUTPUT_FILE=${GITHUB_WORKSPACE}/benchmark-output.json" >> "$GITHUB_ENV"
    - name: Run C-Chain Re-execution Benchmark
      shell: nix develop --impure --command bash -x {0}
-      run: |


Moved this configuration to the script

maru-ava · 2025-12-17T17:32:58Z

.github/actions/c-chain-reexecution-benchmark/action.yml

-    - name: Set task env
+    - name: Set benchmark output file
      shell: bash
-      run: |


EXECUTION_DATA_DIR is now set in the script

.github/actions/c-chain-reexecution-benchmark/action.yml

Copilot

Pull request overview

This PR consolidates C-Chain re-execution logic from multiple Taskfile tasks into a single unified shell script to simplify maintenance and usage.

Key Changes:

Introduces reexecute_cchain.sh script with preset test configurations and custom test support
Removes complex Taskfile orchestration in favor of direct script execution
Simplifies GitHub Actions workflows by replacing task-based invocation with direct script calls

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
scripts/reexecute_cchain.sh	New unified script that handles test presets, S3 data import, execution, and optional post-state pushing
Taskfile.yml	Removes reexecution-related tasks and adds simplified `test-c-chain-reexecution` entry point; simplifies `export-cchain-block-range` task
.github/workflows/c-chain-reexecution-benchmark-gh-native.yml	Updates workflow to use `test` parameter instead of `task` parameter
.github/workflows/c-chain-reexecution-benchmark-gh-native.json	Updates matrix configuration to use `test` instead of `task`
.github/workflows/c-chain-reexecution-benchmark-container.yml	Updates workflow to use `test` parameter instead of `task` parameter
.github/workflows/c-chain-reexecution-benchmark-container.json	Updates matrix configuration to use `test` instead of `task`
.github/actions/c-chain-reexecution-benchmark/action.yml	Simplifies action inputs and logic to call script directly with environment variable overrides

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

scripts/reexecute_cchain.sh

.github/actions/c-chain-reexecution-benchmark/action.yml

aaronbuchwald · 2025-12-17T17:55:12Z

scripts/reexecute_cchain.sh

+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+S3_BOOTSTRAP_BUCKET="${S3_BOOTSTRAP_BUCKET:-s3://avalanchego-bootstrap-testing}"


If I'm not mistaken, we switched to turning each of these sets of parameters into tasks to comply with the notion that tasks should be fully encompassed within the task instead of passing in a bunch of parameters.

I'd argue that a wide range of different sets of options like this is not as common to place within a bash script.

Would you still push to keep each of these baked into one configuration options within this script if we are going to move it out of the taskfile?

I intended for tasks to be both discoverable and to serve as entrypoints into CI so that reproducing CI was as simple as possible. The goal was not to implement anything non-trivial directly in the tasks, though, and I think that the reexec task logic is better maintained outside of the taskfile as I've proposed in this PR.

I think creating a task per reexec test configuration makes about as much sense as creating a task per e2e test. It's still possible to target the execution of an e2e test but it's the e2e test suite that's responsible for enabling that rather than something we need to do in the taskfile. I think it similarly makes sense for there to be an entrypoint in the taskfile for executing reexec tests, and that the entrypoint be responsible for defining both common test configurations and enabling ad-hoc configuration.

aaronbuchwald · 2025-12-17T17:56:59Z

Could you please validate the change by stepping through the README and updating it as needed?

Taskfile.yml

scripts/reexecute_cchain.sh

maru-ava · 2025-12-17T21:21:27Z

Could you please validate the change by stepping through the README and updating it as needed?

Done

maru-ava · 2025-12-18T16:06:46Z

Not ideal that we have a README with complex instructions that have to be manually verified when things change. Mental note: prefer an executable script in future with inline comments instead of a static README.

scripts/import_cchain_data.sh

scripts/benchmark_cchain_range.sh

Taskfile.yml

scripts/benchmark_cchain_range.sh

tests/reexecute/c/README.md

…#1580) ## Why this should be merged Patch is related to #1578 The `aws-launch.sh` script is currently not collecting metrics because it uses the old avalanchego task interface. The new version of avalanchego's [Taskfile.yml](https://github.com/ava-labs/avalanchego/blob/10f374649645f3093023633d60825875c5645589/Taskfile.yml#L204) changed how metrics configuration is passed: - Old: `METRICS_ENABLED` passed as a task variable - New: `METRICS_SERVER_ENABLED` and / or `METRICS_COLLECTOR_ENABLED` passed as environment variables This mismatch causes metrics to silently not be configured when running benchmarks on EC2 instances. Related PRs: - [ava-labs/avalanchego#4761](ava-labs/avalanchego#4761) - [Move from task vars to env](https://github.com/ava-labs/avalanchego/blob/0eebefb80b34849c44c7657a431b57b50e194300/scripts/benchmark_cchain_range.sh#L15) - [ava-labs/avalanchego#4443](ava-labs/avalanchego#4443) ## How this works Changed the bootstrap command from: ```bash task reexecute-cchain-range ... METRICS_ENABLED=false ``` To: ```bash METRICS_SERVER_ENABLED=true task reexecute-cchain-range ... ``` This aligns with how avalanchego's `benchmark_cchain_range.sh` now reads these settings from the environment rather than from task variables. ## How this was tested ### 1. AvalancheGo environment variable behavior Navigate to or clone AvalancheGo: ```bash git clone [email protected]:ava-labs/avalanchego.git cd avalanchego ``` **Default (metrics disabled):** ```bash ./scripts/run_task.sh reexecute-cchain-range \ BLOCK_DIR=/tmp/test \ CURRENT_STATE_DIR=/tmp/test \ START_BLOCK=101 \ END_BLOCK=102 2>&1 | grep -o '"metrics-server-enabled": "[^"]*"' ``` Expected: `"metrics-server-enabled": "false"` **With metrics enabled:** ```bash METRICS_SERVER_ENABLED=true ./scripts/run_task.sh reexecute-cchain-range \ BLOCK_DIR=/tmp/test \ CURRENT_STATE_DIR=/tmp/test \ START_BLOCK=101 \ END_BLOCK=102 2>&1 | grep -o '"metrics-server-enabled": "[^"]*"' ``` Expected: `"metrics-server-enabled": "true"` ### 2. Firewood `aws-launch.sh` flag behavior **Default (metrics enabled):** ```bash ./benchmark/bootstrap/aws-launch.sh --dry-run 2>&1 | grep "Metrics Server:" ``` Expected: `Metrics Server: true` **Disable metrics:** ```bash ./benchmark/bootstrap/aws-launch.sh --dry-run --metrics-server false 2>&1 | grep "Metrics Server:" ``` Expected: `Metrics Server: false` **Case insensitivity:** ```bash ./benchmark/bootstrap/aws-launch.sh --dry-run --metrics-server TRUE 2>&1 | grep "Metrics Server:" ``` Expected: `Metrics Server: true` (normalized to lowercase) **Invalid value (fail fast):** ```bash ./benchmark/bootstrap/aws-launch.sh --metrics-server tru 2>&1 ``` Expected: ``` Error: Invalid --metrics-server value 'tru' Valid values: true, false ```

maru-ava · 2026-01-02T15:04:25Z

Rebased

tests/reexecute/c/README.md

scripts/benchmark_cchain_range.sh

scripts/reexecute_cchain.sh

scripts/benchmark_cchain_range.sh

tests/reexecute/c/README.md

Doing anything non-trivial in tasks is not recommended. This change moves the reexec logic to a new script for ease of maintenance and to simplify usage.

RodrigoVillar

LGTM

## Why this should be merged With ava-labs/avalanchego#4761, invocation of the reexecution test underwent a major refactor. Running the current bootstrap script against the latest version of AvalancheGo results in an error. ## How this works Updates bootstrapping script to use the new invocation of the reexecution test. ## How this was tested Ran `./aws-launch.sh --firewood-branch main --avalanchego-branch master --libevm-branch b8e76562a300 --nblocks 1m` and observed a successful reexecution test.

maru-ava self-assigned this Dec 17, 2025

maru-ava added the ci This focuses on changes to the CI process label Dec 17, 2025

maru-ava added this to avalanchego Dec 17, 2025

maru-ava commented Dec 17, 2025

View reviewed changes

.github/actions/c-chain-reexecution-benchmark/action.yml Show resolved Hide resolved

maru-ava moved this to Ready 🚦 in avalanchego Dec 17, 2025

maru-ava marked this pull request as ready for review December 17, 2025 17:45

maru-ava requested a review from a team as a code owner December 17, 2025 17:45

Copilot AI review requested due to automatic review settings December 17, 2025 17:45

Copilot AI reviewed Dec 17, 2025

View reviewed changes

scripts/reexecute_cchain.sh Outdated Show resolved Hide resolved

.github/actions/c-chain-reexecution-benchmark/action.yml Outdated Show resolved Hide resolved

maru-ava requested review from Elvis339, JuanLeon2, PlatCore, RodrigoVillar and aaronbuchwald December 17, 2025 17:48

aaronbuchwald reviewed Dec 17, 2025

View reviewed changes

RodrigoVillar reviewed Dec 17, 2025

View reviewed changes

Taskfile.yml Show resolved Hide resolved

maru-ava commented Dec 17, 2025

View reviewed changes

scripts/reexecute_cchain.sh Outdated Show resolved Hide resolved

maru-ava mentioned this pull request Dec 17, 2025

test(reexecute): add firewood chaos test [2/2] #4695

Merged

RodrigoVillar reviewed Dec 17, 2025

View reviewed changes

scripts/reexecute_cchain.sh Outdated Show resolved Hide resolved

maru-ava force-pushed the maru/simplify-reexec-tasks branch 3 times, most recently from 91851f9 to 0df3f05 Compare December 18, 2025 15:47

RodrigoVillar reviewed Dec 18, 2025

View reviewed changes

maru-ava force-pushed the maru/simplify-reexec-tasks branch from 0df3f05 to 809baac Compare December 19, 2025 20:13

Elvis339 mentioned this pull request Dec 23, 2025

fix(benchmark): align metrics config with new avalanchego task format ava-labs/firewood#1580

Merged

RodrigoVillar mentioned this pull request Dec 29, 2025

feat(vm_reexecute): add pprof profiling support #4790

Open

maru-ava force-pushed the maru/simplify-reexec-tasks branch from 0eebefb to b241482 Compare January 2, 2026 15:04

maru-ava requested review from RodrigoVillar and aaronbuchwald January 2, 2026 15:04

RodrigoVillar reviewed Jan 5, 2026

View reviewed changes

maru-ava added 9 commits January 5, 2026 14:42

[ci] Migrate reexec tasks to a script to simplify maintenance

d9d8f95

Doing anything non-trivial in tasks is not recommended. This change moves the reexec logic to a new script for ease of maintenance and to simplify usage.

fixup: Rename default test to 'default'

dcd27d4

fixup: Update README

beac43f

fixup: Consolidate the reexec scripts and add import script

2554640

fixup: Add a help argument to output available tests

2623a77

fixup: Fix task name

c06b861

fixup: Respond to review comments

b4666d2

fixup: Stop defaulting to 'custom' in github action

bb1e04b

fixup: Respond to review feedback

0d573ef

maru-ava force-pushed the maru/simplify-reexec-tasks branch from b241482 to 0d573ef Compare January 5, 2026 14:51

RodrigoVillar mentioned this pull request Jan 5, 2026

Convert reexecution documentation to man page #4803

Open

RodrigoVillar approved these changes Jan 5, 2026

View reviewed changes

aaronbuchwald approved these changes Jan 6, 2026

View reviewed changes

maru-ava added this pull request to the merge queue Jan 6, 2026

Merged via the queue into master with commit 25d6216 Jan 6, 2026
53 checks passed

maru-ava deleted the maru/simplify-reexec-tasks branch January 6, 2026 13:03

github-project-automation bot moved this from Ready 🚦 to Done 🎉 in avalanchego Jan 6, 2026

Elvis339 mentioned this pull request Jan 6, 2026

[ci] Support running re-execution benchmark with arbitrary version of Firewood #4650

Open

RodrigoVillar mentioned this pull request Jan 9, 2026

fix(benchmark/bootstrap): update script to use new task ava-labs/firewood#1601

Merged

		SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
		S3_BOOTSTRAP_BUCKET="${S3_BOOTSTRAP_BUCKET:-s3://avalanchego-bootstrap-testing}"

[ci] Migrate reexec tasks to a script to simplify maintenance #4761

[ci] Migrate reexec tasks to a script to simplify maintenance #4761

Uh oh!

Conversation

maru-ava commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why this should be merged

How this was tested

Need to be documented in RELEASES.md?

Uh oh!

maru-ava Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

maru-ava Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

maru-ava Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

maru-ava Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

aaronbuchwald Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

maru-ava Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

aaronbuchwald commented Dec 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maru-ava commented Dec 17, 2025

Uh oh!

maru-ava commented Dec 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maru-ava commented Jan 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RodrigoVillar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

maru-ava commented Dec 17, 2025 •

edited

Loading