ci: ensure generated files up to date in CI #4782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanOppenheimer
added
ci
JonathanOppenheimer
added
evm
| "type": "bytes32" | ||
| } | ||
| ], | ||
| "stateMutability": "nonpayable", |
Member
Author
There was a problem hiding this comment.
This just because of the automatic generation now.
Member
Author
There was a problem hiding this comment.
(the space that is)
| package evm | ||
|
|
||
| // Step 1: Compile ExampleWarp contract to generate ABI and bin files | ||
| //go:generate sh -c "solc-v0.8.30 -o . --overwrite --abi --bin --pretty-json --base-path ../.. --evm-version shanghai ExampleWarp.sol && rm -f IWarpMessenger.abi IWarpMessenger.bin" |
Member
Author
There was a problem hiding this comment.
some test will fail if this if this is on cancun, it's related to the extra PUSH0s. I believe @ARR4N had a fix for this in mind at some point.
maru-ava
reviewed
Dec 22, 2025
maru-ava
approved these changes
Dec 22, 2025
alarso16
approved these changes
Dec 29, 2025
Contributor
alarso16
left a comment
alarso16
left a comment
There was a problem hiding this comment.
This looks ok to me, but I think you should get another EVM approval on this
Elvis339
approved these changes
Jan 2, 2026
Contributor
|
Needs a rebase for the sol conflict and also to pick up the e2e changes. |
…/cleanup-generated-files
Member
Author
Merged instead, but should be good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR adds
//go:generate directivesand CI checks for Solidity-generated files that were previously manually maintained and not verified in CI. It also reorganizes coreth's directory structure to match subnet-evm for consistency --Previously, these Solidity-generated .abi and .bin files were committed to the repository but had no generation scripts or CI verification.
closes #4778
How this works
compile.goand the same CI check that exists in subnet-evm in coreth.How this was tested
CI
Need to be documented in RELEASES.md?
No