Switch to using solc provided by nix #4787
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maru-ava
force-pushed
the
maru/JonathanOppenheimer/cleanup-generated-files
branch
4 times, most recently
from
37baeb6 to
024ea54
Compare
maru-ava
changed the base branch from
master
to
JonathanOppenheimer/cleanup-generated-files
maru-ava
changed the title
maru-ava
force-pushed
the
maru/JonathanOppenheimer/cleanup-generated-files
branch
from
024ea54 to
9924442
Compare
maru-ava
commented
Dec 22, 2025
| working-directory: ./graft/coreth | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: ./.github/actions/setup-go-for-project |
Contributor
Author
There was a problem hiding this comment.
The install-nix action ensures go is installed and that the same caching is enabled.
maru-ava
commented
Dec 22, 2025
| shellcheck: | ||
| desc: Run shellcheck static analysis on all shell scripts with version management | ||
| cmd: ./scripts/shellcheck.sh | ||
| cmd: ../../scripts/shellcheck.sh |
Contributor
Author
There was a problem hiding this comment.
Since the lint jobs now use nix, which provides shellcheck, the old strategy of downloading shellcheck manually is not needed.
JonathanOppenheimer
approved these changes
Dec 22, 2025
Member
JonathanOppenheimer
left a comment
JonathanOppenheimer
left a comment
There was a problem hiding this comment.
love the shellcheck removal too!
Contributor
Author
|
Converting to draft pending #4782 being merged. |
Base automatically changed from
JonathanOppenheimer/cleanup-generated-files
to
master
January 6, 2026 15:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #4782 to replace the use of the setup-solc (v0.8.30) with nix-supplied solc (v0.8.28). This ensures the same version of solidity can be used everywhere via the nix shell - CI/local, macos/linux - without requiring manual installation.