Skip to content

fix(benchmark): align metrics config with new avalanchego task format #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Elvis339 merged 7 commits into from
Dec 30, 2025
Merged

fix(benchmark): align metrics config with new avalanchego task format #1580

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c4a5be3
fix(benchmark): align metrics config with new avalanchego task format
Elvis339 Dec 22, 2025
66a3fa3
chore(aws-launch): remove `METRICS_COLLECTOR_ENABLED`
Elvis339 Dec 22, 2025
b3c520e
chore(aws-launch): default METRICS_SERVER_ENABLED to true
Elvis339 Dec 23, 2025
fa8676d
Merge branch 'main' into es/enable-metrics-in-launch-script
Elvis339 Dec 23, 2025
189d359
feat(benchmark): add --metrics-server flag to aws-launch.sh
Elvis339 Dec 23, 2025
4330fb4
Merge branch 'main' into es/enable-metrics-in-launch-script
Elvis339 Dec 29, 2025
2b8c1fd
Merge branch 'main' into es/enable-metrics-in-launch-script
Elvis339 Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion benchmark/bootstrap/aws-launch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ AVALANCHEGO_BRANCH=""
LIBEVM_BRANCH=""
NBLOCKS="1m"
CONFIG="firewood"
METRICS_SERVER="true"
REGION="us-west-2"
DRY_RUN=false
SPOT_INSTANCE=false
Expand Down Expand Up @@ -63,6 +64,7 @@ show_usage() {
echo " --libevm-branch BRANCH LibEVM git branch to checkout"
echo " --nblocks BLOCKS Number of blocks to download (default: 1m)"
echo " --config CONFIG The VM reexecution config to use (default: firewood)"
echo " --metrics-server BOOL Enable metrics server (true/false, default: true)"
echo " --region REGION AWS region (default: us-west-2)"
echo " --spot Use spot instance pricing (default depends on instance type)"
echo " --dry-run Show the aws command that would be run without executing it"
Expand Down Expand Up @@ -128,6 +130,17 @@ while [[ $# -gt 0 ]]; do
CONFIG="$2"
shift 2
;;
--metrics-server)
# Normalize to lowercase
METRICS_SERVER="${2,,}"
# Validate boolean value
if [[ "$METRICS_SERVER" != "true" && "$METRICS_SERVER" != "false" ]]; then
Copy link
Contributor Author

@Elvis339 Elvis339 Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the team agrees we can also map with common boolean aliases: true|t|1|yes|y|on and false|f|0|no|n|off

Copy link
Contributor

@demosdemon demosdemon Dec 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. Fancier handling can be implemented in fwdctl (#1318).

echo "Error: Invalid --metrics-server value '$2'"
echo "Valid values: true, false"
exit 1
fi
shift 2
;;
--region)
REGION="$2"
shift 2
Expand Down Expand Up @@ -249,6 +262,7 @@ echo " AvalancheGo Branch: ${AVALANCHEGO_BRANCH:-default}"
echo " LibEVM Branch: ${LIBEVM_BRANCH:-default}"
echo " Number of Blocks: $NBLOCKS"
echo " Config: $CONFIG"
echo " Metrics Server: $METRICS_SERVER"
echo " Region: $REGION"
if [ "$SPOT_INSTANCE" = true ]; then
echo " Spot Instance: Yes (max price: \$${MAX_SPOT_PRICES[$INSTANCE_TYPE]})"
Expand Down Expand Up @@ -454,7 +468,7 @@ runcmd:
# execute bootstrapping
- >
sudo -u ubuntu -D /mnt/nvme/ubuntu/avalanchego --login
time task reexecute-cchain-range CURRENT_STATE_DIR=/mnt/nvme/ubuntu/exec-data/current-state BLOCK_DIR=/mnt/nvme/ubuntu/exec-data/blocks START_BLOCK=1 END_BLOCK=__END_BLOCK__ CONFIG=__CONFIG__ METRICS_ENABLED=false
time METRICS_SERVER_ENABLED=__METRICS_SERVER__ task reexecute-cchain-range CURRENT_STATE_DIR=/mnt/nvme/ubuntu/exec-data/current-state BLOCK_DIR=/mnt/nvme/ubuntu/exec-data/blocks START_BLOCK=1 END_BLOCK=__END_BLOCK__ CONFIG=__CONFIG__
> /var/log/bootstrap.log 2>&1
END_HEREDOC
)
Expand All @@ -475,6 +489,7 @@ USERDATA=$(echo "$USERDATA_TEMPLATE" | \
sed "s|__NBLOCKS__|$NBLOCKS|g" | \
sed "s|__END_BLOCK__|$END_BLOCK|g" | \
sed "s|__CONFIG__|$CONFIG|g" | \
sed "s|__METRICS_SERVER__|$METRICS_SERVER|g" | \
base64)
export USERDATA

Expand Down