Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu_vm: add net_dev_disable_option_rom #1759

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codomania
Copy link

In the obsense of romfile= or rombar=0, QEMU will load the iPXE option rom
from the ipxe-roms-qemu package into the network device NIC's ROM BAR.
In some cases you may need to disable the option rom loading.

Signed-off-by: Brijesh Singh [email protected]

In the obsense of romfile= or rombar=0, QEMU will load the iPXE option rom
from the ipxe-roms-qemu package into the network device NIC's ROM BAR.
In some cases you may need to disable the option rom loading.

Signed-off-by: Brijesh Singh <[email protected]>
Copy link
Contributor

@luckyh luckyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@balamuruhans balamuruhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise


# passing romfile= tells QEMU to disable ROM entirely for
# this device
no_romfile = params.get("net_dev_disable_option_rom", None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request to default the params used here and document about the params, its value and its use in cfg

Copy link

@xutian xutian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new parameter is coming, please add comments to introduce the parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants