Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemu_vm: add net_dev_disable_option_rom #1759

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

qemu_vm: add net_dev_disable_option_rom #1759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions virttest/qemu_vm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,12 @@ def add_nic(devices, vlan, model=None, mac=None, device_id=None,
if ctrl_mac_addr and ctrl_mac_addr in ["on", "off"]:
dev.set_param('ctrl_mac_addr', ctrl_mac_addr)
dev.set_param('mac', mac, dynamic=True)

# passing romfile= tells QEMU to disable ROM entirely for
# this device
no_romfile = params.get("net_dev_disable_option_rom", None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request to default the params used here and document about the params, its value and its use in cfg

if no_romfile:
dev.set_param("romfile", "EMPTY_STRING")
# only pci domain=0,bus=0,function=0 is supported for now.
#
# libvirt gains the pci_slot, free_pci_addr here,
Expand Down