test_setup: provide option to check VF count on cleanup #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently `check_vfs_count()` does only check vf count if it matches with hardcoded `driver_option` value during setup, but it will be useful if we use same API to assert during cleanup as well so provide an option to `check_vfs_count()`. Also currently in `set_vf()` the return value of cmd that echos the no of vfs in sysfs is checked, this commit would include to check whether the vf count really matches after echo. Signed-off-by: Balamuruhan S <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently
check_vfs_count()does only check vf count if itmatches with hardcoded
driver_optionvalue during setup,but it will be useful if we use same API to assert during
cleanup as well so provide an option to
check_vfs_count().Also currently in
set_vf()the return value of cmd that echosthe no of vfs in sysfs is checked, this commit would include
to check whether the vf count really matches after echo.
Signed-off-by: Balamuruhan S [email protected]