-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate configure-aws-credentials to use AWS SDK for JavaScript (v3) #680
Comments
seeing this as well |
+1 |
We're also using aws-actions/configure-aws-credentials@v1-node16, same warning. |
The JS v3 SDK no longer supports exporting a global credential object, which is used by our action. A major rewrite of the action and our tests is needed to support v3. This is in progress and will coincide with a v3 release of this action :) |
This comment was marked as off-topic.
This comment was marked as off-topic.
I can't (yet?) confirm any problems from my side, I'm using this action in 30+ workflows and they work; only the message is shown:
This is from an hour ago. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Interestingly, i'm having the exact same issue as you in some of my workflows now. Weirdly I have some workflows which still run OK (albeit showing the warning message about the maintenance mode plans for 2023) but others where this step is failing now. The only differences I can see between these workflows is that the failing ones are declared to run in a container where as the others are not. I wonder if this is the same scenario in your case? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
there is another way to configure credencials? because i'm having the same problem... |
Is this only an issue with setting up credentials directly? What about using OIDC, is that also affected? |
Hi facing similar issue, when trying to load AWS Credentials(v2) via OIDC Please migrate your code to use AWS SDK for JavaScript (v3). |
@mchittineni, this issue is only about removing unaesthetic warning, error you got is not related/caused by this warning. Your error states:
So most likely you are passing wrong or missing role/region/other param. |
@kkurczewski sorry after making the comment i realised my mistake, when i add the permissions the error got changed into a warning and still showing as mentioned below. Run aws-actions/configure-aws-credentials@v2 Please migrate your code to use AWS SDK for JavaScript (v3). |
require('aws-sdk/lib/maintenance_mode_message').suppress = true; |
Is there any update for same ? Due to this we are starting to seen some of the workflows are failing randomly while configuring aws credentials step. |
Happened 2 times in the last 7 days for us. Is there an update on when this will be resolved? |
Same here, it's happening quite often today. |
I was thinking this was my issue, but it turns out I was running into this: Adding to the thread since others might be hitting the same problem, even tho its not directly related. |
When I follow the instructions in the blog post things work. But I don't understand where they are getting the
Where does this thumbprint in the blog post come from? |
For some context, here's the certificate chain that I see for GHA in Google Chrome: I believe that you are looking at the last certificate (Github's cert), but for AWS OIDC you generally want the first intermediate, which is the second certificate in the list. This is because the first certificate can't be used and the last certificate is renewed at least annually:
Note that this is all a relic of AWS OIDC being paranoid enough to not use the trusted CA list maintained by OSs and browsers. I'd love to see a "Internet root trust store" option from AWS so we can stop worrying about rotating fingerprints 🤷🏻 |
Hello everyone, the error that you're seeing related to thumbprints and certificates is not related to JavaScript v3. This is a tracking issue for the v3 migration, which we already have in progress. We work extremely closely with the JavaScript SDK team and migrating this action to the new version will happen before the SDK is fully deprecated. For any discussion related to certificate thumbprints, please see #357. |
Just to confirm, the warning you're seeing as a result of the v2 SDK being used is merely cosmetic at this time. |
The error is not due to the SDK version, but something else. The message you see there is just a warning unrelated to the error. Please open up another issue with the details of your workflow @Blunderchips |
Ok, will do it when I get a chance. Stopped working over the weekend with no changes our side. |
i get exact same issue as Blunderchips when trying to setup this github action for the first time, with a very basic workflow |
Yes, same error. It worked on the Friday then not on the Monday. Of course, our keys are defined and are still valid. |
Thanks for the info @kellertk . Do you have an ETA of when this will be released? And will this include the other aws actions (ie amazon-ecs-deploy-task-definition)? |
Same here, worked on Friday, stopped working on Monday, nothing changed on our pipeline or AWS |
I faced the same errors. Adding following to the top of my deployment.yaml fixed it:
|
Closed by #791 |
** Note ** |
Describe the feature
Use Case
There is a warning message when we use
aws-actions/configure-aws-credentials@v1-node16
in GitHub Actions workflow.Proposed Solution
Migrate configure-aws-credentials to use AWS SDK for JavaScript (v3)
Other Information
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: