Merged
Conversation
zhongkechen
force-pushed
the
callback
branch
2 times, most recently
from
7d0582c to
d1b4cc3
Compare
Contributor
Author
|
I need to include the error type fix as well: aws/aws-durable-execution-sdk-python#313 |
| if (stepOp != null) { | ||
| var stepError = stepOp.stepDetails().error(); | ||
| if (StepInterruptedException.isStepInterruptedException(stepError)) { | ||
| throw new CallbackSubmitterException(callbackOp, new StepInterruptedException(stepOp)); |
Contributor
There was a problem hiding this comment.
Will this cause NPE if callbackOp is null?
Contributor
Author
There was a problem hiding this comment.
No, callbackOp is always created before stepOp. I've updated the error handling logic in the latest commit to fix a different issue. Please check again
ayushiahjolia
approved these changes
Mar 4, 2026
nvasiu
pushed a commit
to nvasiu/aws-durable-execution-sdk-java
that referenced
this pull request
Mar 5, 2026
* add waitForCallback * fix cloud test cases for waitForCallback * add unit tests * fix exception type * update step name * fix error handling * add name length validator
This was referenced Mar 5, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
Fix: #89
Description
waitForCallbackto DurableContextChildContextOperationto supportsubTypewithSkipTime.runUntilCompletealways auto advance. For manual advance, userun+advanceTimeinstead.Demo/Screenshots
the screenshot is outdated.
-stephas been renamed to-submitterChecklist
Testing
Unit Tests
Have unit tests been written for these changes? Yes
Integration Tests
Have integration tests been written for these changes? N/A
Examples
Has a new example been added for the change? (if applicable) Yes