-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement legacy callback with BIO_set_callback #2285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… callback and callback_ex
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2285 +/- ##
==========================================
+ Coverage 79.02% 79.05% +0.03%
==========================================
Files 614 614
Lines 106934 107103 +169
Branches 15145 15178 +33
==========================================
+ Hits 84504 84675 +171
+ Misses 21777 21775 -2
Partials 653 653 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
reviewed
Mar 21, 2025
smittals2
reviewed
Mar 21, 2025
smittals2
reviewed
Mar 21, 2025
smittals2
reviewed
Mar 21, 2025
justsmth
reviewed
Mar 21, 2025
justsmth
reviewed
Mar 21, 2025
… call get_callback() this will not break but simply drop extra arguments
…r legacy callback into callback_fn_wrap_ex; BIO_puts now only uses get_callback
justsmth
reviewed
Mar 26, 2025
…into static function handle_callback_return
justsmth
reviewed
Mar 26, 2025
smittals2
reviewed
Mar 27, 2025
smittals2
reviewed
Mar 27, 2025
smittals2
reviewed
Mar 27, 2025
smittals2
reviewed
Mar 27, 2025
justsmth
previously approved these changes
Mar 27, 2025
smittals2
reviewed
Mar 27, 2025
smittals2
reviewed
Mar 27, 2025
smittals2
reviewed
Mar 27, 2025
smittals2
reviewed
Mar 27, 2025
justsmth
approved these changes
Mar 28, 2025
smittals2
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #CRYPTOALG-3030
Description of changes:
Adds legacy callback to BIO meeting previous application compatibility.
Router function implemented to prefer enhanced callback but provide legacy callback if needed and available.
Call-outs:
We now check if callback is NULL after checking if we have a callback.
Rather than calling enhanced callback directly we check with router function get_callback
Testing:
Updated parameters for BIOPairTest to include boolean pairs enabling current enhanced callback testing to test for legacy callback.
Changed multiple tests from BIOTest to BIOPairTest for parameterized testing.
Will be adding test for get_callback in future PR
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.