Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement legacy callback with BIO_set_callback #2285

Merged
merged 29 commits into from
Apr 7, 2025

Conversation

kingstjo
Copy link
Contributor

Issues:

Addresses #CRYPTOALG-3030

Description of changes:

Adds legacy callback to BIO meeting previous application compatibility.
Router function implemented to prefer enhanced callback but provide legacy callback if needed and available.

Call-outs:

We now check if callback is NULL after checking if we have a callback.
Rather than calling enhanced callback directly we check with router function get_callback

Testing:

Updated parameters for BIOPairTest to include boolean pairs enabling current enhanced callback testing to test for legacy callback.
Changed multiple tests from BIOTest to BIOPairTest for parameterized testing.
Will be adding test for get_callback in future PR

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@kingstjo kingstjo requested a review from a team as a code owner March 20, 2025 21:33
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 95.68966% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.05%. Comparing base (652f7a9) to head (18362cd).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crypto/bio/bio.c 93.42% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2285      +/-   ##
==========================================
+ Coverage   79.02%   79.05%   +0.03%     
==========================================
  Files         614      614              
  Lines      106934   107103     +169     
  Branches    15145    15178      +33     
==========================================
+ Hits        84504    84675     +171     
+ Misses      21777    21775       -2     
  Partials      653      653              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kingstjo kingstjo requested review from justsmth and smittals2 March 26, 2025 19:23
justsmth
justsmth previously approved these changes Mar 27, 2025
@kingstjo kingstjo marked this pull request as draft March 27, 2025 20:56
@kingstjo kingstjo marked this pull request as ready for review March 28, 2025 00:18
@kingstjo kingstjo requested a review from smittals2 March 28, 2025 20:16
@samuel40791765 samuel40791765 merged commit 54453b4 into aws:main Apr 7, 2025
105 of 109 checks passed
@kingstjo kingstjo deleted the implement-callback-dump branch April 7, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants