Implement legacy callback with BIO_set_callback by kingstjo · Pull Request #2285 · aws/aws-lc

Commits on Mar 19, 2025

Updated parameters for BIOPairTest to cover combinations of callback and callback_ex
kingstjo
committed
Updated TestPutsCallbacks to use BIOPairTest to cover combinations of callback and callback_ex
kingstjo
committed
Updated Tests to use BIOPairTest to cover combinations of callback and callback_ex
kingstjo
committed

Commits on Mar 20, 2025

Commits on Mar 21, 2025

arguments len and processed aren't handled for legacy callback, as we call get_callback() this will not break but simply drop extra arguments
kingstjo
committed

Commits on Mar 25, 2025

Commits on Mar 26, 2025

Commits on Mar 27, 2025

Commits on Mar 28, 2025

add defensive assert for callback_fn_wrap_ex ensuring callback_ex is not available
kingstjo
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement legacy callback with BIO_set_callback#2285

Commits on Mar 19, 2025

Updated parameters for BIOPairTest to cover combinations of callback and callback_ex

Updated TestPutsCallbacks to use BIOPairTest to cover combinations of callback and callback_ex

Updated Tests to use BIOPairTest to cover combinations of callback and callback_ex

Commits on Mar 20, 2025

updated TestPutsCallback only takes in bool pair for callback type

Updated comments, grouped callback_ex verifications

Added old-style callback, replaced direct calls to callback_ex with get_callback

Updated comment styling

Merge branch 'aws:main' into implement-callback-dump

Commits on Mar 21, 2025

arguments len and processed aren't handled for legacy callback, as we call get_callback() this will not break but simply drop extra arguments

Commits on Mar 25, 2025

fixed signature BIO_callback_fn to properly reflect bio_ret as long

moved call_bio_callback_with_processed logic for len and processed for legacy callback into callback_fn_wrap_ex; BIO_puts now only uses get_callback

BIO_write is now using get_callback instead of call_bio_callback_with_processed

BIO_read now uses get_callback instead of call_bio_callback_with_processed

BIO_gets now uses get_callback instead of call_bio_callback_with_processed

With router get_callback additional check for null made macro HAS_CALLBACK redundant

Commits on Mar 26, 2025

removed usage of macro HAS_LEN_OPER

Moved redundant callback return logic for operations using processed into static function handle_callback_return

Added missing check before casting size_t to int

fixed indentations

moved assignment of return value into processed for read, write, puts, and gets operations

replace checks with assert in internal use function

Updated comments to better reflect hanlding of additional arguments for legacy callbacks

Commits on Mar 27, 2025

Fixed implicit casting long to int

Added comments explaining reset of ret value

Fixed spacing and inline declarations

properly check long is within INT bounds

removed added new lines

Updated callback_fn_wrap_ex to not use processed if callback returns 0

Commits on Mar 28, 2025

add defensive assert for callback_fn_wrap_ex ensuring callback_ex is not available