fix(git_action): remove python3.7 & 3.8 #7844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr/external
stage/needs-triage
seshubaws
approved these changes
Jan 23, 2025
|
Do we want to add python 3.12 and 13 while we're making these changes? |
For tests cases, they already have a case for 3.12 and 13. |
vicheey
reviewed
Jan 23, 2025
| @@ -55,7 +55,6 @@ jobs: | |||
| - ubuntu-latest | |||
| - windows-latest | |||
| python: | |||
| - "3.8" | |||
| - "3.9" | |||
There was a problem hiding this comment.
Just for context here, do we know why we are not having 3.10 for make pr here?
There was a problem hiding this comment.
We can add one if necessary, but be aware this is a matrix and there will be 10+ more jobs added to git action for every PR
vicheey
approved these changes
Jan 23, 2025
| @@ -244,8 +240,6 @@ jobs: | |||
| with: | |||
| # These are the versions of Python that correspond to the supported Lambda runtimes | |||
| python-version: | | |||
| 3.7 | |||
| 3.8 | |||
There was a problem hiding this comment.
For visibility, Lambda will support function creation until Feb 28, 2025.
| Name | Identifier | Operating system | Deprecation date | Block function create | Block function update |
|---|---|---|---|---|---|
| Python 3.8 | python3.8 | Amazon Linux 2 | Oct 14, 2024 | Feb 28, 2025 | Mar 31, 2025 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
How does it address the issue?
What side effects does this change have?
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.