fix(git_action): remove python3.7 & 3.8 #7844
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -595,7 +595,7 @@ def test_build_layer_with_architecture_not_compatible(self, build_method, use_co | |
| # Build should still succeed | ||
| self.assertEqual(command_result.process.returncode, 0) | ||
|
|
||
| @parameterized.expand([("python3.11", False), ("python3.11", "use_container")]) | ||
| def test_build_arch_no_compatible_arch(self, runtime, use_container): | ||
| # BuildArchitecture is present, but CompatibleArchitectures section is missing | ||
| if use_container and (SKIP_DOCKER_TESTS or SKIP_DOCKER_BUILD): | ||
|
|
@@ -621,7 +621,7 @@ def test_build_arch_no_compatible_arch(self, runtime, use_container): | |
| # Build should still succeed | ||
| self.assertEqual(command_result.process.returncode, 0) | ||
|
|
||
| @parameterized.expand([("python3.11", False), ("python3.11", "use_container")]) | ||
| def test_compatible_arch_no_build_arch(self, runtime, use_container): | ||
| # CompatibleArchitectures is present, but BuildArchitecture section is missing | ||
| if use_container and (SKIP_DOCKER_TESTS or SKIP_DOCKER_BUILD): | ||
|
|
@@ -691,7 +691,7 @@ def test_function_build_succeeds_with_referenced_layer(self, use_container): | |
| if use_container and (SKIP_DOCKER_TESTS or SKIP_DOCKER_BUILD): | ||
| self.skipTest(SKIP_DOCKER_MESSAGE) | ||
|
|
||
| overrides = {"Runtime": "python3.11", "CodeUri": "Python"} | ||
|
|
||
| cmdlist = self.get_command_list( | ||
| use_container=use_container, parameter_overrides=overrides, function_identifier="FunctionTwo" | ||
|
|
@@ -1123,7 +1123,7 @@ def test_no_cached_override_build(self): | |
| "FunctionCodeUri": "Python", | ||
| "Function1Handler": "main.first_function_handler", | ||
| "Function2Handler": "main.second_function_handler", | ||
| "FunctionRuntime": "python3.11", | ||
| } | ||
| config_file = str(Path(self.test_data_path).joinpath("samconfig_no_cached.toml")) | ||
| cmdlist = self.get_command_list(parameter_overrides=overrides, cached=True) | ||
|
|
@@ -1161,7 +1161,7 @@ def test_cached_build_with_env_vars(self): | |
| "FunctionCodeUri": "Python", | ||
| "Function1Handler": "main.first_function_handler", | ||
| "Function2Handler": "main.second_function_handler", | ||
| "FunctionRuntime": "python3.11", | ||
| } | ||
| cmdlist = self.get_command_list( | ||
| use_container=True, parameter_overrides=overrides, cached=True, container_env_var="FOO=BAR" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,19 +32,16 @@ class TestBuildCommand_PythonFunctions_With_Specified_Architecture_arm64(BuildIn | |
|
|
||
| @parameterized.expand( | ||
| [ | ||
| ("python3.9", "Python", False), | ||
| ("python3.10", "Python", False), | ||
| ("python3.11", "Python", False), | ||
| ("python3.12", "Python", False), | ||
| ("python3.13", "Python", False), | ||
| ("python3.9", "PythonPEP600", False), | ||
| ("python3.10", "PythonPEP600", False), | ||
| ("python3.11", "PythonPEP600", False), | ||
| ("python3.12", "PythonPEP600", False), | ||
| ("python3.13", "PythonPEP600", False), | ||
| ("python3.9", "Python", "use_container"), | ||
| ("python3.10", "Python", "use_container"), | ||
| ("python3.11", "Python", "use_container"), | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -261,11 +261,9 @@ def test_windows_dockerfile_present_sub_dir(self, dockerfile, expected): | |
| "codeuri", | ||
| ), | ||
| [ | ||
| ("python3.9", "Python"), | ||
| ("python3.10", "Python"), | ||
| ("python3.11", "Python"), | ||
| ("python3.9", "PythonPEP600"), | ||
| ("python3.10", "PythonPEP600"), | ||
| ("python3.11", "PythonPEP600"), | ||
|
|
@@ -345,7 +343,6 @@ class TestBuildCommand_PythonFunctions_WithDocker(BuildIntegPythonBase): | |
|
|
||
| @parameterized.expand( | ||
| [ | ||
| ("python3.9",), | ||
| ("python3.10",), | ||
| ("python3.11",), | ||
|
|
@@ -467,15 +464,12 @@ class TestBuildCommand_PythonFunctions_With_Specified_Architecture(BuildIntegPyt | |
|
|
||
| @parameterized.expand( | ||
| [ | ||
| ("python3.9", "Python", False, "x86_64"), | ||
| ("python3.10", "Python", False, "x86_64"), | ||
| ("python3.11", "Python", False, "x86_64"), | ||
| ("python3.9", "PythonPEP600", False, "x86_64"), | ||
| ("python3.10", "PythonPEP600", False, "x86_64"), | ||
| ("python3.11", "PythonPEP600", False, "x86_64"), | ||
| ("python3.9", "Python", "use_container", "x86_64"), | ||
| ("python3.10", "Python", "use_container", "x86_64"), | ||
| ("python3.11", "Python", "use_container", "x86_64"), | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,7 +57,7 @@ def test_samconfig_fails_properly_with_incorrect_extension(self): | |
| ] | ||
| ) | ||
| def test_samconfig_parameters_are_overridden(self, extension): | ||
| overrides = {"Runtime": "python3.11"} | ||
| overridden_build_dir = f"override_{extension}" | ||
|
|
||
| cmdlist = self.get_command_list( | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for context here, do we know why we are not having 3.10 for
make prhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add one if necessary, but be aware this is a matrix and there will be 10+ more jobs added to git action for every PR