Skip to content

Conversation

@seshubaws
Copy link
Contributor

Problem

Solution


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@seshubaws seshubaws requested a review from a team as a code owner October 24, 2025 20:48
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@seshubaws seshubaws changed the title Fix/flaky test fix: flaky walkthrough test Oct 24, 2025
// When
await genWalkthroughProject('API', workspaceUri, 'python')
const genPromise = genWalkthroughProject('API', workspaceUri, 'python')
await getTestWindow().waitForMessage(/template.yaml already exist/)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test times out, is it unable to find this?

Copy link
Contributor Author

@seshubaws seshubaws Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably the "scanning cloudformation template" warning shows up before the confirm overwrite popup, still working on it. I'm not able to repro the error in my local

@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@seshubaws seshubaws changed the title fix: flaky walkthrough test test: flaky walkthrough test Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants