Skip to content

test: flaky walkthrough test #8236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 27, 2025
Merged

test: flaky walkthrough test #8236

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1573275
add timeout for flaky test
seshubaws Oct 24, 2025
70a2a32
add timeout for flaky test
seshubaws Oct 24, 2025
defb921
add timeout for flaky test
seshubaws Oct 24, 2025
3b51e83
add check for elements
seshubaws Oct 24, 2025
397cd60
disable codelens to remove cfn scanner
seshubaws Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/core/src/test/awsService/appBuilder/walkthrough.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,11 @@ describe('AppBuilder Walkthrough', function () {
assert.notEqual(await fs.readFileText(vscode.Uri.joinPath(workspaceUri, 'template.yaml')), prevInfo)
})

it.skip('download serverlessland proj', async function () {
it('download serverlessland proj', async function () {
// When
await genWalkthroughProject('API', workspaceUri, 'python')
const genPromise = genWalkthroughProject('API', workspaceUri, 'python')
await getTestWindow().waitForMessage(/template.yaml already exist/)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test times out, is it unable to find this?

Copy link
Contributor Author

@seshubaws seshubaws Oct 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably the "scanning cloudformation template" warning shows up before the confirm overwrite popup, still working on it. I'm not able to repro the error in my local

await genPromise
// Then template should be overwritten
assert.equal(await fs.exists(vscode.Uri.joinPath(workspaceUri, 'template.yaml')), true)
assert.notEqual(await fs.readFileText(vscode.Uri.joinPath(workspaceUri, 'template.yaml')), prevInfo)
Expand Down
Loading