Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .net framework version to 4.5.2 #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enif-lee
Copy link

@enif-lee enif-lee commented Sep 2, 2019

*Issue #97 *

Change symbols of .NET Framework 4.5 to 4.5.2

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@enif-lee
Copy link
Author

enif-lee commented Sep 2, 2019

This changes is something wrong. In my thinking, New Line Syntax is changes.

Could you tell me which new line syntax is lf or crlf? and how about using .editorconfig?

@srprash
Copy link
Collaborator

srprash commented Sep 3, 2019

Hi @enif-lee ,
Thanks for taking the time to submit this PR. I see that currently most of the files are with LF line endings but there are few CRLFs too. This is because the repo has been updated from different OS. I think using a .gitattribute file can be a better option and we would be able to define line endings at the repo level which is convenient and uniform for all the contributors.

@enif-lee enif-lee force-pushed the dotnet-version-update branch from b841675 to 0108448 Compare September 11, 2020 05:53
@enif-lee
Copy link
Author

@srprash Yeah, The new line configuration of attribute is already done on #132 and it seems to be working fine.

@bhautikpip bhautikpip requested a review from srprash September 22, 2020 00:28
@srprash
Copy link
Collaborator

srprash commented Oct 5, 2020

Great! We can get this merged and released for our next major version. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants